linter: enable in CI & make deterministic

This commit is contained in:
Zach Ramsay 2017-12-10 22:11:24 +00:00
parent fca2b508c1
commit d6e821ea4f
2 changed files with 6 additions and 7 deletions

View File

@ -1,7 +1,7 @@
GOTOOLS = \ GOTOOLS = \
github.com/mitchellh/gox \ github.com/mitchellh/gox \
github.com/Masterminds/glide \ github.com/Masterminds/glide \
github.com/alecthomas/gometalinter \ gopkg.in/alecthomas/gometalinter.v2 \
github.com/ckaznocha/protoc-gen-lint \ github.com/ckaznocha/protoc-gen-lint \
github.com/gogo/protobuf/protoc-gen-gogo \ github.com/gogo/protobuf/protoc-gen-gogo \
github.com/gogo/protobuf/gogoproto github.com/gogo/protobuf/gogoproto
@ -62,7 +62,7 @@ get_deps:
ensure_tools: ensure_tools:
go get -u -v $(GOTOOLS) go get -u -v $(GOTOOLS)
@gometalinter --install @gometalinter.v2 --install
get_vendor_deps: ensure_tools get_vendor_deps: ensure_tools
@rm -rf vendor/ @rm -rf vendor/
@ -71,11 +71,11 @@ get_vendor_deps: ensure_tools
metalinter: metalinter:
protoc $(INCLUDE) --lint_out=. types/*.proto protoc $(INCLUDE) --lint_out=. types/*.proto
gometalinter --vendor --deadline=600s --enable-all --disable=lll ./... gometalinter.v2 --vendor --deadline=600s --enable-all --disable=lll ./...
metalinter_test: metalinter_test:
protoc $(INCLUDE) --lint_out=. types/*.proto #protoc $(INCLUDE) --lint_out=. types/*.proto
gometalinter --vendor --deadline=600s --disable-all \ gometalinter.v2 --vendor --deadline=600s --disable-all \
--enable=maligned \ --enable=maligned \
--enable=deadcode \ --enable=deadcode \
--enable=goconst \ --enable=goconst \

View File

@ -2,7 +2,6 @@ machine:
environment: environment:
GOPATH: /home/ubuntu/.go_workspace GOPATH: /home/ubuntu/.go_workspace
REPO: $GOPATH/src/github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME REPO: $GOPATH/src/github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME
GO15VENDOREXPERIMENT: 1
hosts: hosts:
circlehost: 127.0.0.1 circlehost: 127.0.0.1
localhost: 127.0.0.1 localhost: 127.0.0.1
@ -16,7 +15,7 @@ checkout:
test: test:
override: override:
- cd $REPO && make get_vendor_deps && make test_integrations - cd $REPO && make get_vendor_deps && make metalinter_test && make test_integrations
post: post:
- cd "$REPO" && bash <(curl -s https://codecov.io/bash) -f coverage.txt - cd "$REPO" && bash <(curl -s https://codecov.io/bash) -f coverage.txt
- cd "$REPO" && mv coverage.txt "${CIRCLE_ARTIFACTS}" - cd "$REPO" && mv coverage.txt "${CIRCLE_ARTIFACTS}"