fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-06-14 13:51:21 +00:00
Code Issues Projects Releases Wiki Activity

lil fixes

Browse Source
This commit is contained in:
Zach Ramsay
2017-10-03 19:48:43 -04:00
committed by Ethan Buchman
parent 7ad8a8ab55
commit d033470817
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
p2p/addrbook.go
View File

@ -371,7 +371,7 @@ func (a *AddrBook) loadFromFile(filePath string) bool {
if err != nil { if err != nil {
cmn.PanicCrisis(cmn.Fmt("Error opening file %s: %v", filePath, err)) cmn.PanicCrisis(cmn.Fmt("Error opening file %s: %v", filePath, err))
} }
defer r.Close() // nolint (errcheck) defer r.Close() // nolint: errcheck
aJSON := &addrBookJSON{} aJSON := &addrBookJSON{}
dec := json.NewDecoder(r) dec := json.NewDecoder(r)
err = dec.Decode(aJSON) err = dec.Decode(aJSON)

2
p2p/connection.go
View File

@ -184,7 +184,7 @@ func (c *MConnection) OnStop() {
if c.quit != nil { if c.quit != nil {
close(c.quit) close(c.quit)
} }
c.conn.Close() // nolint (errcheck) c.conn.Close() // nolint: errcheck
// We can't close pong safely here because // We can't close pong safely here because
// recvRoutine may write to it after we've stopped. // recvRoutine may write to it after we've stopped.
// Though it doesn't need to get closed at all, // Though it doesn't need to get closed at all,

2
p2p/listener.go
View File

@ -117,7 +117,7 @@ func (l *DefaultListener) OnStart() error {
func (l *DefaultListener) OnStop() { func (l *DefaultListener) OnStop() {
l.BaseService.OnStop() l.BaseService.OnStop()
l.listener.Close() // nolint (errcheck) l.listener.Close() // nolint: errcheck
} }
// Accept connections and pass on the channel // Accept connections and pass on the channel

4
p2p/secret_connection.go
View File

@ -302,7 +302,7 @@ func shareAuthSignature(sc *SecretConnection, pubKey crypto.PubKeyEd25519, signa
// sha256 // sha256
func hash32(input []byte) (res *[32]byte) { func hash32(input []byte) (res *[32]byte) {
hasher := sha256.New() hasher := sha256.New()
_, _ = hasher.Write(input) // ignoring error _, _ = hasher.Write(input) // error ignored
resSlice := hasher.Sum(nil) resSlice := hasher.Sum(nil)
res = new([32]byte) res = new([32]byte)
copy(res[:], resSlice) copy(res[:], resSlice)
@ -312,7 +312,7 @@ func hash32(input []byte) (res *[32]byte) {
// We only fill in the first 20 bytes with ripemd160 // We only fill in the first 20 bytes with ripemd160
func hash24(input []byte) (res *[24]byte) { func hash24(input []byte) (res *[24]byte) {
hasher := ripemd160.New() hasher := ripemd160.New()
_, _ = hasher.Write(input) // ignoring error _, _ = hasher.Write(input) // error ignored
resSlice := hasher.Sum(nil) resSlice := hasher.Sum(nil)
res = new([24]byte) res = new([24]byte)
copy(res[:], resSlice) copy(res[:], resSlice)

2
rpc/lib/client/ws_client_test.go
View File

@ -105,7 +105,7 @@ func TestWSClientReconnectsAfterWriteFailure(t *testing.T) {
// hacky way to abort the connection before write // hacky way to abort the connection before write
if err := c.conn.Close(); err != nil { if err := c.conn.Close(); err != nil {
panic(err) t.Error(err)
} }
// results in WS write error, the client should resend on reconnect // results in WS write error, the client should resend on reconnect