fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-05-29 06:01:21 +00:00
Code Issues Projects Releases Wiki Activity

Fixed a blockchain pool goroutine-leak bug

Browse Source
This commit is contained in:
Jae Kwon 2015-10-12 16:49:46 -07:00
parent fd9f816050
commit cb3a1fd095
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
blockchain/pool.go
View File

@ -162,14 +162,18 @@ func (pool *BlockPool) PopRequest() {
pool.mtx.Lock() // Lock pool.mtx.Lock() // Lock
defer pool.mtx.Unlock() defer pool.mtx.Unlock()
/* The block can disappear at any time, due to removePeer(). if r := pool.requesters[pool.height]; r != nil {
if r := pool.requesters[pool.height]; r == nil || r.block == nil { /* The block can disappear at any time, due to removePeer().
PanicSanity("PopRequest() requires a valid block") if r := pool.requesters[pool.height]; r == nil || r.block == nil {
PanicSanity("PopRequest() requires a valid block")
}
*/
r.Stop()
delete(pool.requesters, pool.height)
pool.height++
} else {
PanicSanity(Fmt("Expected requester to pop, got nothing at height %v", pool.height))
} }
*/
delete(pool.requesters, pool.height)
pool.height++
} }
// Invalidates the block at pool.height, // Invalidates the block at pool.height,