db: some test cleanup

db/backend_test.go

@@ -58,7 +58,6 @@ func TestBackendsNilKeys(t *testing.T) {
 		name := cmn.Fmt("test_%x", cmn.RandStr(12))
 		db, err := creator(name, "")
 		assert.Nil(t, err)
-		defer os.RemoveAll(name)
 
 		assertPanics(t, dbType, "get", func() { db.Get(nil) })
 		assertPanics(t, dbType, "has", func() { db.Has(nil) })
@@ -68,13 +67,18 @@ func TestBackendsNilKeys(t *testing.T) {
 		assertPanics(t, dbType, "deletesync", func() { db.DeleteSync(nil) })
 
 		db.Close()
+		err = os.RemoveAll(name + ".db")
+		assert.Nil(t, err)
 	}
 }
 
-func TestLevelDBBackendStr(t *testing.T) {
+func TestGoLevelDBBackendStr(t *testing.T) {
 	name := cmn.Fmt("test_%x", cmn.RandStr(12))
 	db := NewDB(name, LevelDBBackendStr, "")
-	defer os.RemoveAll(name)
+	defer os.RemoveAll(name + ".db")
-	_, ok := db.(*GoLevelDB)
+
-	assert.True(t, ok)
+	if _, ok := backends[CLevelDBBackendStr]; !ok {
+		_, ok := db.(*GoLevelDB)
+		assert.True(t, ok)
+	}
 }

db/c_level_db_test.go

@@ -5,8 +5,10 @@ package db
 import (
 	"bytes"
 	"fmt"
+	"os"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
 	cmn "github.com/tendermint/tmlibs/common"
 )
 
@@ -84,3 +86,12 @@ func bytes2Int64(buf []byte) int64 {
 	return int64(binary.BigEndian.Uint64(buf))
 }
 */
+
+func TestCLevelDBBackendStr(t *testing.T) {
+	name := cmn.Fmt("test_%x", cmn.RandStr(12))
+	db := NewDB(name, LevelDBBackendStr, "")
+	defer os.RemoveAll(name)
+
+	_, ok := db.(*CLevelDB)
+	assert.True(t, ok)
+}

db/db.go

@@ -6,7 +6,7 @@ import "fmt"
 // Main entry
 
 const (
-	LevelDBBackendStr   = "leveldb" // legacy, defaults to goleveldb.
+	LevelDBBackendStr   = "leveldb" // legacy, defaults to goleveldb unless +gcc
 	CLevelDBBackendStr  = "cleveldb"
 	GoLevelDBBackendStr = "goleveldb"
 	MemDBBackendStr     = "memdb"