fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-04-25 23:02:16 +00:00
Code Issues Projects Releases Wiki Activity

adr-029: update CheckBlock

Browse Source
This commit is contained in:
Ethan Buchman 2018-10-04 20:11:21 -04:00
parent be1760cc25
commit c15fc9ff63
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
docs/architecture/adr-021-check block txs before prevote.md → docs/architecture/adr-029-check-tx-consensus.md
View File

@ -1,7 +1,9 @@
# ADR 021: check block txs before prevote # ADR 029: Check block txs before prevote
## Changelog ## Changelog
04-10-2018: Update with link to issue
[#2384](https://github.com/tendermint/tendermint/issues/2384) and reason for rejection
19-09-2018: Initial Draft 19-09-2018: Initial Draft
## Context ## Context
@ -104,7 +106,11 @@ An optional optimization is alter the deliverTx to deliverBlock. For the block h
## Status ## Status
Proposed. Rejected
## Decision
Performance impact is considered too great. See [#2384](https://github.com/tendermint/tendermint/issues/2384)
## Consequences ## Consequences
@ -115,5 +121,8 @@ Proposed.
### Negative ### Negative
- add a new interface method. app logic needs to adjust to appeal to it. - add a new interface method. app logic needs to adjust to appeal to it.
- sending all the tx data over the ABCI twice
- potentially redundant validations (eg. signature checks in both CheckBlock and
DeliverTx)
### Neutral ### Neutral