fix linting (#4000)

This commit is contained in:
Marko 2019-09-19 15:31:28 +02:00 committed by Ethan Buchman
parent b3b30a5e70
commit bf989eb272
4 changed files with 5 additions and 6 deletions

View File

@ -45,3 +45,4 @@ linters:
# disabled-checks: # disabled-checks:
# - wrapperFunc # - wrapperFunc
# - commentFormatting # https://github.com/go-critic/go-critic/issues/755 # - commentFormatting # https://github.com/go-critic/go-critic/issues/755

View File

@ -13,16 +13,14 @@ type timeCheck struct {
} }
func schedulerHandle(event Event) (Event, error) { func schedulerHandle(event Event) (Event, error) {
switch event.(type) { if _, ok := event.(timeCheck); ok {
case timeCheck:
fmt.Println("scheduler handle timeCheck") fmt.Println("scheduler handle timeCheck")
} }
return noOp, nil return noOp, nil
} }
func processorHandle(event Event) (Event, error) { func processorHandle(event Event) (Event, error) {
switch event.(type) { if _, ok := event.(timeCheck); ok {
case timeCheck:
fmt.Println("processor handle timeCheck") fmt.Println("processor handle timeCheck")
} }
return noOp, nil return noOp, nil

View File

@ -42,6 +42,7 @@ func newRoutine(name string, handleFunc handleFunc, bufferSize int) *Routine {
} }
} }
// nolint: unused
func (rt *Routine) setLogger(logger log.Logger) { func (rt *Routine) setLogger(logger log.Logger) {
rt.logger = logger rt.logger = logger
} }

View File

@ -15,8 +15,7 @@ type eventA struct {
var done = fmt.Errorf("done") var done = fmt.Errorf("done")
func simpleHandler(event Event) (Event, error) { func simpleHandler(event Event) (Event, error) {
switch event.(type) { if _, ok := event.(eventA); ok {
case eventA:
return noOp, done return noOp, done
} }
return noOp, nil return noOp, nil