errcheck: PR comment fixes

This commit is contained in:
Zach Ramsay
2017-09-21 09:55:06 -04:00
committed by Ethan Buchman
parent b3c5933a23
commit b75d4f73e7
12 changed files with 34 additions and 58 deletions

View File

@ -534,6 +534,7 @@ func (wsc *wsConnection) readRoutine() {
}
}
}()
defer wsc.baseConn.Close()
wsc.baseConn.SetPongHandler(func(m string) error {
return wsc.baseConn.SetReadDeadline(time.Now().Add(wsc.readWait))
@ -546,7 +547,7 @@ func (wsc *wsConnection) readRoutine() {
default:
// reset deadline for every type of message (control or data)
if err := wsc.baseConn.SetReadDeadline(time.Now().Add(wsc.readWait)); err != nil {
panic(err)
wsc.Logger.Error("failed to set read deadline", "err", err)
}
var in []byte
_, in, err := wsc.baseConn.ReadMessage()
@ -619,9 +620,7 @@ func (wsc *wsConnection) writeRoutine() {
pingTicker := time.NewTicker(wsc.pingPeriod)
defer func() {
pingTicker.Stop()
if err := wsc.baseConn.Close(); err != nil {
panic(err)
}
wsc.baseConn.Close()
}()
// https://github.com/gorilla/websocket/issues/97
@ -781,6 +780,6 @@ func writeListOfEndpoints(w http.ResponseWriter, r *http.Request, funcMap map[st
w.WriteHeader(200)
_, err := w.Write(buf.Bytes())
if err != nil {
panic(err)
// ignore error
}
}

View File

@ -58,7 +58,7 @@ func WriteRPCResponseHTTPError(w http.ResponseWriter, httpCode int, res types.RP
w.WriteHeader(httpCode)
_, err = w.Write(jsonBytes)
if err != nil {
panic(err)
// ignore error
}
}
@ -71,7 +71,7 @@ func WriteRPCResponseHTTP(w http.ResponseWriter, res types.RPCResponse) {
w.WriteHeader(200)
_, err = w.Write(jsonBytes)
if err != nil {
panic(err)
// ignore error
}
}