fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-07-31 12:11:58 +00:00
Code Issues Projects Releases Wiki Activity

remove extra call to Exists

Browse Source 
Refs #345

https://github.com/tendermint/tendermint/issues/1539#issuecomment-387240606
This commit is contained in:
Anton Kaliaev
2018-05-17 11:52:07 +04:00
parent 0908e668bd
commit ae572b9038
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mempool/mempool.go
View File

@@ -203,10 +203,9 @@ func (mem *Mempool) CheckTx(tx types.Tx, cb func(*abci.Response)) (err error) {
defer mem.proxyMtx.Unlock() defer mem.proxyMtx.Unlock()
// CACHE // CACHE
if mem.cache.Exists(tx) { if !mem.cache.Push(tx) {
return ErrTxInCache return ErrTxInCache
} }
mem.cache.Push(tx)
// END CACHE // END CACHE
// WAL // WAL
@@ -463,14 +462,6 @@ func (cache *txCache) Reset() {
cache.mtx.Unlock() cache.mtx.Unlock()
} }
// Exists returns true if the given tx is cached.
func (cache *txCache) Exists(tx types.Tx) bool {
cache.mtx.Lock()
_, exists := cache.map_[string(tx)]
cache.mtx.Unlock()
return exists
}
// Push adds the given tx to the txCache. It returns false if tx is already in the cache. // Push adds the given tx to the txCache. It returns false if tx is already in the cache.
func (cache *txCache) Push(tx types.Tx) bool { func (cache *txCache) Push(tx types.Tx) bool {
cache.mtx.Lock() cache.mtx.Lock()