review comments:

- re-add test
- add TODO
- err instead of panic where possible
This commit is contained in:
Liamsi
2018-06-21 11:51:46 -07:00
parent c96b27136f
commit a39b2522d5
3 changed files with 52 additions and 2 deletions

View File

@ -76,7 +76,7 @@ func (pv *MockPV) SignProposal(chainID string, proposal *Proposal) error {
signBytes := proposal.SignBytes(chainID)
sig, err := pv.privKey.Sign(signBytes)
if err != nil {
panic(err)
return err
}
proposal.Signature = sig
return nil
@ -86,7 +86,7 @@ func (pv *MockPV) SignProposal(chainID string, proposal *Proposal) error {
func (pv *MockPV) SignHeartbeat(chainID string, heartbeat *Heartbeat) error {
sig, err := pv.privKey.Sign(heartbeat.SignBytes(chainID))
if err != nil {
panic(err)
return err
}
heartbeat.Signature = sig
return nil