fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-06-06 10:01:19 +00:00
Code Issues Projects Releases Wiki Activity

reintroduce mtx for remote signer calls

Browse Source
This commit is contained in:
Ismail Khoffi 2018-12-18 17:04:15 +01:00
parent 138a57258f
commit 96b5d8719c
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
privval/remote_signer.go
View File

@ -4,6 +4,7 @@ import (
"fmt" "fmt"
"io" "io"
"net" "net"
"sync"
"github.com/pkg/errors" "github.com/pkg/errors"
@ -18,6 +19,7 @@ import (
type RemoteSignerClient struct { type RemoteSignerClient struct {
conn net.Conn conn net.Conn
consensusPubKey crypto.PubKey consensusPubKey crypto.PubKey
mtx sync.Mutex
} }
// Check that RemoteSignerClient implements PrivValidator. // Check that RemoteSignerClient implements PrivValidator.
@ -45,6 +47,9 @@ func (sc *RemoteSignerClient) GetPubKey() crypto.PubKey {
} }
func (sc *RemoteSignerClient) getPubKey() (crypto.PubKey, error) { func (sc *RemoteSignerClient) getPubKey() (crypto.PubKey, error) {
sc.mtx.Lock()
defer sc.mtx.Unlock()
err := writeMsg(sc.conn, &PubKeyRequest{}) err := writeMsg(sc.conn, &PubKeyRequest{})
if err != nil { if err != nil {
return nil, err return nil, err
@ -68,6 +73,9 @@ func (sc *RemoteSignerClient) getPubKey() (crypto.PubKey, error) {
// SignVote implements PrivValidator. // SignVote implements PrivValidator.
func (sc *RemoteSignerClient) SignVote(chainID string, vote *types.Vote) error { func (sc *RemoteSignerClient) SignVote(chainID string, vote *types.Vote) error {
sc.mtx.Lock()
defer sc.mtx.Unlock()
err := writeMsg(sc.conn, &SignVoteRequest{Vote: vote}) err := writeMsg(sc.conn, &SignVoteRequest{Vote: vote})
if err != nil { if err != nil {
return err return err
@ -95,6 +103,9 @@ func (sc *RemoteSignerClient) SignProposal(
chainID string, chainID string,
proposal *types.Proposal, proposal *types.Proposal,
) error { ) error {
sc.mtx.Lock()
defer sc.mtx.Unlock()
err := writeMsg(sc.conn, &SignProposalRequest{Proposal: proposal}) err := writeMsg(sc.conn, &SignProposalRequest{Proposal: proposal})
if err != nil { if err != nil {
return err return err
@ -118,6 +129,9 @@ func (sc *RemoteSignerClient) SignProposal(
// Ping is used to check connection health. // Ping is used to check connection health.
func (sc *RemoteSignerClient) Ping() error { func (sc *RemoteSignerClient) Ping() error {
sc.mtx.Lock()
defer sc.mtx.Unlock()
err := writeMsg(sc.conn, &PingRequest{}) err := writeMsg(sc.conn, &PingRequest{})
if err != nil { if err != nil {
return err return err