3291 follow-up (#3323)

* changelog: use issue number instead of PR number

* follow up to #3291

- rpc/test/helpers.go add StopTendermint(node) func
- remove ensureDir(filepath.Dir(walFile), 0700)
- mempool/mempool_test.go add type cleanupFunc func()

* cmd/show_validator: wrap err to make it more clear

rpc/client/main_test.go

@@ -13,14 +13,12 @@ var node *nm.Node
 
 func TestMain(m *testing.M) {
 	// start a tendermint node (and kvstore) in the background to test against
-	var cleanup func()
 	app := kvstore.NewKVStoreApplication()
-	node, cleanup = rpctest.StartTendermint(app)
+	node = rpctest.StartTendermint(app)
+
 	code := m.Run()
 
 	// and shut down proper at the end
-	node.Stop()
-	node.Wait()
-	cleanup()
+	rpctest.StopTendermint(node)
 	os.Exit(code)
 }