Apply suggestions from code review

Comment from PR

Co-Authored-By: Ethan Buchman <ethan@coinculture.info>
This commit is contained in:
Marko
2019-07-12 11:06:27 +02:00
committed by GitHub
parent e8926867d8
commit 823d916a11

View File

@ -8,8 +8,8 @@ Special thanks to external contributors on this release:
@ParthDesai, @climber73, @jim380, @ashleyvega @ParthDesai, @climber73, @jim380, @ashleyvega
This release contains breaking changes to our libs folder and ABCI namely: This release contains breaking changes to our libs folder and ABCI namely:
- Add a "Recheck Tx" indicator - CheckTx requests include a `CheckTxType` enum that can be set to `Recheck` to indicate to the application that this transaction was already checked/validated and certain expensive operations (like checking signatures) can be skipped
- Removal of `db/debugDB`, `common/colors.go`, `errors/errors.go`, `common/heap.go`, `date.go`, `io.go` and - Removed various functions from `libs` pkgs
`GoPath()`, `Prompt()` and `IsDirEmpty()` functions from `os.go` `GoPath()`, `Prompt()` and `IsDirEmpty()` functions from `os.go`
Friendly reminder, we have a [bug bounty Friendly reminder, we have a [bug bounty
@ -38,8 +38,7 @@ program](https://hackerone.com/tendermint).
### FEATURES: ### FEATURES:
- [node] Refactor `NewNode` to use functional options to make it more flexible - [node] Add variadic argument to `NewNode` to support functional options, allowing the Node to be more easily customized.
and extensible in the future.
- [node][\#3730](https://github.com/tendermint/tendermint/pull/3730) Add `CustomReactors` option to `NewNode` allowing caller to pass - [node][\#3730](https://github.com/tendermint/tendermint/pull/3730) Add `CustomReactors` option to `NewNode` allowing caller to pass
custom reactors to run inside Tendermint node (@ParthDesai) custom reactors to run inside Tendermint node (@ParthDesai)