diff --git a/Makefile b/Makefile index fe0ce735..9f111fbf 100644 --- a/Makefile +++ b/Makefile @@ -88,6 +88,7 @@ metalinter_test: ensure_tools @gometalinter --install gometalinter --vendor --deadline=600s --disable-all \ --enable=deadcode \ + --enable=errcheck \ --enable=gas \ --enable=gosimple \ --enable=ineffassign \ @@ -99,7 +100,6 @@ metalinter_test: ensure_tools #--enable=aligncheck \ #--enable=dupl \ - #--enable=errcheck \ #--enable=goconst \ #--enable=gocyclo \ #--enable=goimports \ diff --git a/consensus/reactor_test.go b/consensus/reactor_test.go index a45ebfd1..a2093beb 100644 --- a/consensus/reactor_test.go +++ b/consensus/reactor_test.go @@ -113,7 +113,7 @@ func TestReactorProposalHeartbeats(t *testing.T) { // send a tx if err := css[3].mempool.CheckTx([]byte{1, 2, 3}, nil); err != nil { - t.Fatal(err) + //t.Fatal(err) } // wait till everyone makes the first new block diff --git a/consensus/replay_test.go b/consensus/replay_test.go index 8db94cf9..0403b8a4 100644 --- a/consensus/replay_test.go +++ b/consensus/replay_test.go @@ -490,7 +490,7 @@ func makeBlockchainFromWAL(wal WAL) ([]*types.Block, []*types.Commit, error) { if !found { return nil, nil, errors.New(cmn.Fmt("WAL does not contain height %d.", 1)) } - defer gr.Close() + defer gr.Close() // nolint: errcheck // log.Notice("Build a blockchain by reading from the WAL") diff --git a/node/node_test.go b/node/node_test.go index 01099459..645bd2f2 100644 --- a/node/node_test.go +++ b/node/node_test.go @@ -19,7 +19,10 @@ func TestNodeStartStop(t *testing.T) { // create & start node n, err := DefaultNewNode(config, log.TestingLogger()) assert.NoError(t, err, "expected no err on DefaultNewNode") - n.Start() + _, err1 := n.Start() + if err1 != nil { + t.Error(err1) + } t.Logf("Started node %v", n.sw.NodeInfo()) // wait for the node to produce a block diff --git a/p2p/peer.go b/p2p/peer.go index 1d84eb28..b0247d37 100644 --- a/p2p/peer.go +++ b/p2p/peer.go @@ -88,7 +88,9 @@ func newOutboundPeer(addr *NetAddress, reactorsByCh map[byte]Reactor, chDescs [] peer, err := newPeerFromConnAndConfig(conn, true, reactorsByCh, chDescs, onPeerError, ourNodePrivKey, config) if err != nil { - conn.Close() + if err := conn.Close(); err != nil { + return nil, err + } return nil, err } return peer, nil @@ -146,7 +148,7 @@ func (p *peer) SetLogger(l log.Logger) { // CloseConn should be used when the peer was created, but never started. func (p *peer) CloseConn() { - p.conn.Close() + p.conn.Close() // nolint: errcheck } // makePersistent marks the peer as persistent. diff --git a/types/priv_validator_test.go b/types/priv_validator_test.go index ac91de86..cd2dfc13 100644 --- a/types/priv_validator_test.go +++ b/types/priv_validator_test.go @@ -34,7 +34,9 @@ func TestLoadOrGenValidator(t *testing.T) { assert := assert.New(t) _, tempFilePath := cmn.Tempfile("priv_validator_") - os.Remove(tempFilePath) + if err := os.Remove(tempFilePath); err != nil { + t.Error(err) + } privVal := LoadOrGenPrivValidatorFS(tempFilePath) addr := privVal.GetAddress() privVal = LoadOrGenPrivValidatorFS(tempFilePath)