From 70cd985a940a5c306ae5383df701bceb3a2f44cb Mon Sep 17 00:00:00 2001 From: folex <0xdxdy@gmail.com> Date: Fri, 6 Sep 2019 16:26:32 +0200 Subject: [PATCH] Add TODO question --- state/execution_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/state/execution_test.go b/state/execution_test.go index 863de421..4fedbf83 100644 --- a/state/execution_test.go +++ b/state/execution_test.go @@ -64,7 +64,8 @@ func TestBeginBlockValidators(t *testing.T) { now := tmtime.Now() commitSig0 := (&types.Vote{ValidatorIndex: 0, Timestamp: now, Type: types.PrecommitType}).CommitSig() - commitSig1 := (&types.Vote{ValidatorIndex: 1, Timestamp: now, Type: types.PrecommitType}).CommitSig() + // TODO: why the Type is not set here? It shows a panic on %+v; REMOVE THIS ON REVIEW + commitSig1 := (&types.Vote{ValidatorIndex: 1, Timestamp: now}).CommitSig() testCases := []struct { desc string @@ -138,6 +139,7 @@ func TestBeginBlockByzantineValidators(t *testing.T) { } commitSig0 := (&types.Vote{ValidatorIndex: 0, Timestamp: now, Type: types.PrecommitType}).CommitSig() + // TODO: why the Type is not set here? It shows a panic on %+v; REMOVE THIS ON REVIEW commitSig1 := (&types.Vote{ValidatorIndex: 1, Timestamp: now}).CommitSig() commitSigs := []*types.CommitSig{commitSig0, commitSig1} lastCommit := types.NewCommit(prevBlockID, commitSigs)