service#Start, service#Stop signatures were changed

See https://github.com/tendermint/tmlibs/issues/45

rpc/client/event_test.go

@@ -27,9 +27,8 @@ func TestHeaderEvents(t *testing.T) {
 		// start for this test it if it wasn't already running
 		if !c.IsRunning() {
 			// if so, then we start it, listen, and stop it.
-			st, err := c.Start()
+			err := c.Start()
 			require.Nil(err, "%d: %+v", i, err)
-			require.True(st, "%d", i)
 			defer c.Stop()
 		}
 
@@ -48,9 +47,8 @@ func TestBlockEvents(t *testing.T) {
 		// start for this test it if it wasn't already running
 		if !c.IsRunning() {
 			// if so, then we start it, listen, and stop it.
-			st, err := c.Start()
+			err := c.Start()
 			require.Nil(err, "%d: %+v", i, err)
-			require.True(st, "%d", i)
 			defer c.Stop()
 		}
 
@@ -80,9 +78,8 @@ func TestTxEventsSentWithBroadcastTxAsync(t *testing.T) {
 		// start for this test it if it wasn't already running
 		if !c.IsRunning() {
 			// if so, then we start it, listen, and stop it.
-			st, err := c.Start()
+			err := c.Start()
 			require.Nil(err, "%d: %+v", i, err)
-			require.True(st, "%d", i)
 			defer c.Stop()
 		}
 
@@ -113,9 +110,8 @@ func TestTxEventsSentWithBroadcastTxSync(t *testing.T) {
 		// start for this test it if it wasn't already running
 		if !c.IsRunning() {
 			// if so, then we start it, listen, and stop it.
-			st, err := c.Start()
+			err := c.Start()
 			require.Nil(err, "%d: %+v", i, err)
-			require.True(st, "%d", i)
 			defer c.Stop()
 		}
 

rpc/client/httpclient.go

@@ -215,26 +215,26 @@ func newWSEvents(remote, endpoint string) *WSEvents {
 // Start is the only way I could think the extend OnStart from
 // events.eventSwitch.  If only it wasn't private...
 // BaseService.Start -> eventSwitch.OnStart -> WSEvents.Start
-func (w *WSEvents) Start() (bool, error) {
+func (w *WSEvents) Start() error {
 	ws := rpcclient.NewWSClient(w.remote, w.endpoint, rpcclient.OnReconnect(func() {
 		w.redoSubscriptions()
 	}))
-	started, err := ws.Start()
+	err := ws.Start()
 	if err == nil {
 		w.ws = ws
 		go w.eventListener()
 	}
-	return started, errors.Wrap(err, "StartWSEvent")
+	return err
 }
 
 // Stop wraps the BaseService/eventSwitch actions as Start does
-func (w *WSEvents) Stop() bool {
+func (w *WSEvents) Stop() error {
 	// send a message to quit to stop the eventListener
 	w.quit <- true
 	<-w.done
 	w.ws.Stop()
 	w.ws = nil
-	return true
+	return nil
 }
 
 func (w *WSEvents) Subscribe(ctx context.Context, query string, out chan<- interface{}) error {