address linting FIXMEs

This commit is contained in:
Ethan Buchman
2017-11-27 21:48:15 +00:00
parent c4caad7720
commit 55b81cc1a1
6 changed files with 29 additions and 55 deletions

View File

@@ -79,6 +79,8 @@ func TestABCIMock(t *testing.T) {
func TestABCIRecorder(t *testing.T) {
assert, require := assert.New(t), require.New(t)
// This mock returns errors on everything but Query
m := mock.ABCIMock{
Info: mock.Call{Response: abci.ResponseInfo{
Data: "data",
@@ -92,15 +94,13 @@ func TestABCIRecorder(t *testing.T) {
require.Equal(0, len(r.Calls))
r.ABCIInfo()
_, err := r.ABCIInfo()
if err != nil {
t.Error(err)
}
_, err = r.ABCIQueryWithOptions("path", data.Bytes("data"), client.ABCIQueryOptions{Trusted: false})
if err != nil {
// t.Errorf(err) FIXME: fails
}
assert.Nil(err, "expected no err on info")
_, err = r.ABCIInfo()
assert.Nil(err, "expected no err on info")
_, err := r.ABCIQueryWithOptions("path", data.Bytes("data"), client.ABCIQueryOptions{Trusted: false})
assert.NotNil(err, "expected error on query")
require.Equal(2, len(r.Calls))
info := r.Calls[0]
@@ -125,20 +125,14 @@ func TestABCIRecorder(t *testing.T) {
assert.EqualValues("data", qa.Data)
assert.False(qa.Trusted)
// now add some broadcasts
// now add some broadcasts (should all err)
txs := []types.Tx{{1}, {2}, {3}}
_, err = r.BroadcastTxCommit(txs[0])
if err != nil {
// t.Error(err) FIXME: fails
}
assert.NotNil(err, "expected err on broadcast")
_, err = r.BroadcastTxSync(txs[1])
if err != nil {
// t.Error(err) FIXME: fails
}
assert.NotNil(err, "expected err on broadcast")
_, err = r.BroadcastTxAsync(txs[2])
if err != nil {
// t.Error(err) FIXME: fails
}
assert.NotNil(err, "expected err on broadcast")
require.Equal(5, len(r.Calls))