fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-04-26 07:12:16 +00:00
Code Issues Projects Releases Wiki Activity

fixes from review

Browse Source
This commit is contained in:
Ethan Buchman 2018-06-23 09:20:08 -04:00
parent f6ff6b0e15
commit 500fca8efe
2 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
docs/architecture/adr-009-ABCI-design.md
View File

@ -16,7 +16,7 @@ The ABCI was first introduced in late 2015. It's purpose is to be:
This means ABCI should provide an interface for both pluggable applications and This means ABCI should provide an interface for both pluggable applications and
pluggable consensus engines. pluggable consensus engines.
To achieve this, it uses Protocol Buffers for message types. The dominant To achieve this, it uses Protocol Buffers (proto3) for message types. The dominant
implementation is in Go. implementation is in Go.
After some recent discussions with the community on github, the following were After some recent discussions with the community on github, the following were
@ -30,8 +30,10 @@ See the [references](#references) for more.
### Imports ### Imports
The native proto library in Go generates code that is inellegant and difficult to work with. The native proto library in Go generates inflexible and verbose code.
The solution in the Go community is to use a fork of it called `gogoproto`. Many in the Go community have adopted a fork called
[gogoproto](https://github.com/gogo/protobuf) that provides a
variety of features aimed to improve the developer experience.
While `gogoproto` is nice, it creates an additional dependency, and compiling While `gogoproto` is nice, it creates an additional dependency, and compiling
the protobuf types for other languages has been reported to fail when `gogoproto` is used. the protobuf types for other languages has been reported to fail when `gogoproto` is used.
@ -49,12 +51,16 @@ we want it to be easy to use.
### PubKey ### PubKey
PubKeys were previously encoded using Amino (and before that, go-wire). PubKeys are encoded using Amino (and before that, go-wire).
Ideally, PubKeys are an interface type where we don't know all the
implementation types, so its unfitting to use `oneof` or `enum`.
### Addresses ### Addresses
The address for an ED25519 pubkey is currently the RIPEMD160 of the Amino The address for ED25519 pubkey is the RIPEMD160 of the Amino
encoded pubkey. encoded pubkey. This introduces an Amino dependency in the address generation,
a functionality that is widely required and should be easy to compute as
possible.
### Validators ### Validators
@ -136,8 +142,9 @@ where `type` can be:
- "ed225519", with `data = <raw 32-byte pubkey>` - "ed225519", with `data = <raw 32-byte pubkey>`
- "secp256k1", with `data = <33-byte OpenSSL compressed pubkey>` - "secp256k1", with `data = <33-byte OpenSSL compressed pubkey>`
and generated types. At the least we should use a reflection-based protobuf so
we can just encode our own types, rather than using protobuf generated ones. As we want to retain flexibility here, and since ideally, PubKey would be an
interface type, we do not use `enum` or `oneof`.
### Addresses ### Addresses
@ -199,7 +206,7 @@ Since ResponseEndBlock includes Validator, it must now include their address.
### InitChain ### InitChain
Change RequestInitChain and ResponseInitChain to Change RequestInitChain to give the app all the information from the genesis file:
``` ```
message RequestInitChain { message RequestInitChain {
@ -209,7 +216,12 @@ message RequestInitChain {
repeated Validator validators repeated Validator validators
bytes app_state_bytes bytes app_state_bytes
} }
```
Change ResponseInitChain to allow the app to specify the initial validator set
and consensus parameters.
```
message ResponseInitChain { message ResponseInitChain {
ConsensusParams consensus_params ConsensusParams consensus_params
repeated Validator validators repeated Validator validators
@ -218,7 +230,7 @@ message ResponseInitChain {
### Header ### Header
Now that Tendermint Amino will be compatible with Proto3, the Header in ABCI Now that Tendermint Amino will be compatible with proto3, the Header in ABCI
should exactly match the Tendermint header - they will then be encoded should exactly match the Tendermint header - they will then be encoded
identically in ABCI and in Tendermint Core. identically in ABCI and in Tendermint Core.

4
docs/architecture/adr-010-crypto-changes.md
View File

@ -8,7 +8,7 @@ After nearly 4 years of development, Tendermint has recently undergone multiple
### Hash Functions ### Hash Functions
Tendermint currently uses RIPEMD160 universally as a hash function, most notably in its Merkle tree implementation. Tendermint uses RIPEMD160 universally as a hash function, most notably in its Merkle tree implementation.
RIPEMD160 was chosen because it provides the shortest fingerprint that is long enough to be considered secure (ie. birthday bound of 80-bits). RIPEMD160 was chosen because it provides the shortest fingerprint that is long enough to be considered secure (ie. birthday bound of 80-bits).
It was also developed in the open academic community, unlike NSA-designed algorithms like SHA256. It was also developed in the open academic community, unlike NSA-designed algorithms like SHA256.
@ -24,6 +24,8 @@ It uses RIPEMD160.
### Addresses ### Addresses
ED25519 addresses are computed using the RIPEMD160 of the Amino encoding of the public key. ED25519 addresses are computed using the RIPEMD160 of the Amino encoding of the public key.
RIPEMD160 is generally considered an outdated hash function, and is much slower
than more modern functions like SHA256 or Blake2.
### Authenticated Encryption ### Authenticated Encryption