fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-04-25 14:52:17 +00:00
Code Issues Projects Releases Wiki Activity

crypto: Abstract pubkey / signature size when known to constants (#1808)

Browse Source 
* crypto: Abstract pubkey / signature size when known to constants

* Created PubKeyEd25519Size as 32
* Created PubkeySecp256k1Size as 33
* Created SignatureEd25519Size as 64

* Remove extraneous message from changelog
This commit is contained in:
Dev Ojha 2018-06-29 00:08:01 -07:00 committed by Anton Kaliaev
parent e26d6ed448
commit 41733b46b9
3 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -2,6 +2,9 @@
## TBD ## TBD
IMPROVEMENTS:
- [crypto] Make public key size into public constants
BUG FIXES: BUG FIXES:
- [rpc] limited number of HTTP/WebSocket connections - [rpc] limited number of HTTP/WebSocket connections
(`rpc.max_open_connections`) and gRPC connections (`rpc.max_open_connections`) and gRPC connections

16
crypto/pub_key.go
View File

@ -40,8 +40,10 @@ type PubKey interface {
var _ PubKey = PubKeyEd25519{} var _ PubKey = PubKeyEd25519{}
const PubKeyEd25519Size = 32
// Implements PubKeyInner // Implements PubKeyInner
type PubKeyEd25519 [32]byte type PubKeyEd25519 [PubKeyEd25519Size]byte
// Address is the SHA256-20 of the raw pubkey bytes. // Address is the SHA256-20 of the raw pubkey bytes.
func (pubKey PubKeyEd25519) Address() Address { func (pubKey PubKeyEd25519) Address() Address {
@ -62,15 +64,15 @@ func (pubKey PubKeyEd25519) VerifyBytes(msg []byte, sig_ Signature) bool {
if !ok { if !ok {
return false return false
} }
pubKeyBytes := [32]byte(pubKey) pubKeyBytes := [PubKeyEd25519Size]byte(pubKey)
sigBytes := [64]byte(sig) sigBytes := [SignatureEd25519Size]byte(sig)
return ed25519.Verify(&pubKeyBytes, msg, &sigBytes) return ed25519.Verify(&pubKeyBytes, msg, &sigBytes)
} }
// For use with golang/crypto/nacl/box // For use with golang/crypto/nacl/box
// If error, returns nil. // If error, returns nil.
func (pubKey PubKeyEd25519) ToCurve25519() *[32]byte { func (pubKey PubKeyEd25519) ToCurve25519() *[PubKeyEd25519Size]byte {
keyCurve25519, pubKeyBytes := new([32]byte), [32]byte(pubKey) keyCurve25519, pubKeyBytes := new([PubKeyEd25519Size]byte), [PubKeyEd25519Size]byte(pubKey)
ok := extra25519.PublicKeyToCurve25519(keyCurve25519, &pubKeyBytes) ok := extra25519.PublicKeyToCurve25519(keyCurve25519, &pubKeyBytes)
if !ok { if !ok {
return nil return nil
@ -94,10 +96,12 @@ func (pubKey PubKeyEd25519) Equals(other PubKey) bool {
var _ PubKey = PubKeySecp256k1{} var _ PubKey = PubKeySecp256k1{}
const PubKeySecp256k1Size = 33
// Implements PubKey. // Implements PubKey.
// Compressed pubkey (just the x-cord), // Compressed pubkey (just the x-cord),
// prefixed with 0x02 or 0x03, depending on the y-cord. // prefixed with 0x02 or 0x03, depending on the y-cord.
type PubKeySecp256k1 [33]byte type PubKeySecp256k1 [PubKeySecp256k1Size]byte
// Implements Bitcoin style addresses: RIPEMD160(SHA256(pubkey)) // Implements Bitcoin style addresses: RIPEMD160(SHA256(pubkey))
func (pubKey PubKeySecp256k1) Address() Address { func (pubKey PubKeySecp256k1) Address() Address {

4
crypto/signature.go
View File

@ -25,8 +25,10 @@ type Signature interface {
var _ Signature = SignatureEd25519{} var _ Signature = SignatureEd25519{}
const SignatureEd25519Size = 64
// Implements Signature // Implements Signature
type SignatureEd25519 [64]byte type SignatureEd25519 [SignatureEd25519Size]byte
func (sig SignatureEd25519) Bytes() []byte { func (sig SignatureEd25519) Bytes() []byte {
bz, err := cdc.MarshalBinaryBare(sig) bz, err := cdc.MarshalBinaryBare(sig)