save historical consensus params

state/state_test.go

@@ -192,6 +192,65 @@ func TestValidatorChangesSaveLoad(t *testing.T) {
 	}
 }
 
+// TestConsensusParamsChangesSaveLoad tests saving and loading consensus params with changes.
+func TestConsensusParamsChangesSaveLoad(t *testing.T) {
+	tearDown, _, state := setupTestCase(t)
+	defer tearDown(t)
+	// nolint: vetshadow
+	assert := assert.New(t)
+
+	// change vals at these heights
+	changeHeights := []int64{1, 2, 4, 5, 10, 15, 16, 17, 20}
+	N := len(changeHeights)
+
+	// each valset is just one validator.
+	// create list of them
+	params := make([]types.ConsensusParams, N+1)
+	params[0] = state.ConsensusParams
+	for i := 1; i < N+1; i++ {
+		params[i] = *types.DefaultConsensusParams()
+		params[i].BlockSize.MaxBytes += i
+	}
+
+	// build the params history by running SetBlockAndValidators
+	// with the right params set for each height
+	highestHeight := changeHeights[N-1] + 5
+	changeIndex := 0
+	cp := params[changeIndex]
+	for i := int64(1); i < highestHeight; i++ {
+		// when we get to a change height,
+		// use the next params
+		if changeIndex < len(changeHeights) && i == changeHeights[changeIndex] {
+			changeIndex++
+			cp = params[changeIndex]
+		}
+		header, parts, responses := makeHeaderPartsResponsesParams(state, i, cp)
+		state.SetBlockAndValidators(header, parts, responses)
+		state.saveConsensusParamsInfo()
+	}
+
+	// make all the test cases by using the same params until after the change
+	testCases := make([]paramsChangeTestCase, highestHeight)
+	changeIndex = 0
+	cp = params[changeIndex]
+	for i := int64(1); i < highestHeight+1; i++ {
+		// we we get to the height after a change height
+		// use the next pubkey (note our counter starts at 0 this time)
+		if changeIndex < len(changeHeights) && i == changeHeights[changeIndex]+1 {
+			changeIndex++
+			cp = params[changeIndex]
+		}
+		testCases[i-1] = paramsChangeTestCase{i, cp}
+	}
+
+	for _, testCase := range testCases {
+		p, err := state.LoadConsensusParams(testCase.height)
+		assert.Nil(err, fmt.Sprintf("expected no err at height %d", testCase.height))
+		assert.Equal(testCase.params, p, fmt.Sprintf(`unexpected consensus params at
+                height %d`, testCase.height))
+	}
+}
+
 func makeParams(blockBytes, blockTx, blockGas, txBytes,
 	txGas, partSize int) types.ConsensusParams {
 
@@ -199,11 +258,11 @@ func makeParams(blockBytes, blockTx, blockGas, txBytes,
 		BlockSize: types.BlockSize{
 			MaxBytes: blockBytes,
 			MaxTxs:   blockTx,
-			MaxGas:   blockGas,
+			MaxGas:   int64(blockGas),
 		},
 		TxSize: types.TxSize{
 			MaxBytes: txBytes,
-			MaxGas:   txGas,
+			MaxGas:   int64(txGas),
 		},
 		BlockGossip: types.BlockGossip{
 			BlockPartSizeBytes: partSize,
@@ -252,7 +311,7 @@ func TestApplyUpdates(t *testing.T) {
 	}
 
 	for i, tc := range cases {
-		res := applyUpdates(tc.init, tc.updates)
+		res := tc.init.Update(tc.updates)
 		assert.Equal(t, tc.expected, res, "case %d", i)
 	}
 }
@@ -284,3 +343,19 @@ type valChangeTestCase struct {
 	height int64
 	vals   crypto.PubKey
 }
+
+func makeHeaderPartsResponsesParams(state *State, height int64,
+	params types.ConsensusParams) (*types.Header, types.PartSetHeader, *ABCIResponses) {
+
+	block := makeBlock(state, height)
+	abciResponses := &ABCIResponses{
+		Height:   height,
+		EndBlock: &abci.ResponseEndBlock{ConsensusParamUpdates: types.TM2PB.ConsensusParams(&params)},
+	}
+	return block.Header, types.PartSetHeader{}, abciResponses
+}
+
+type paramsChangeTestCase struct {
+	height int64
+	params types.ConsensusParams
+}