fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-06-24 10:11:48 +00:00
Code Issues Projects Releases Wiki Activity

fixes from Jae's review

Browse Source 
1. remove pointer
2. add Quit() method to Service interface
This commit is contained in:
Anton Kaliaev
2018-02-12 14:31:52 +04:00
parent f1c8489270
commit 2a24ae90c1
21 changed files with 38 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
rpc/lib/server/handlers.go
View File

@ -484,7 +484,7 @@ func (wsc *wsConnection) GetEventSubscriber() types.EventSubscriber {
// It implements WSRPCConnection. It is Goroutine-safe.
func (wsc *wsConnection) WriteRPCResponse(resp types.RPCResponse) {
select {
case <-wsc.Quit:
case <-wsc.Quit():
return
case wsc.writeChan <- resp:
}
@ -494,7 +494,7 @@ func (wsc *wsConnection) WriteRPCResponse(resp types.RPCResponse) {
// It implements WSRPCConnection. It is Goroutine-safe
func (wsc *wsConnection) TryWriteRPCResponse(resp types.RPCResponse) bool {
select {
case <-wsc.Quit:
case <-wsc.Quit():
return false
case wsc.writeChan <- resp:
return true
@ -525,7 +525,7 @@ func (wsc *wsConnection) readRoutine() {
for {
select {
case <-wsc.Quit:
case <-wsc.Quit():
return
default:
// reset deadline for every type of message (control or data)
@ -643,7 +643,7 @@ func (wsc *wsConnection) writeRoutine() {
return
}
}
case <-wsc.Quit:
case <-wsc.Quit():
return
}
}