Roman Borschel 8cec457b5e

[multistream-select] Require remaining negotiation data to be flushed. (#1781) ...

* Require remaining negotiation data to be flushed.

There appears to still be an edge-case whereby the
`remaining` data to send w.r.t. protocol negotiation to send
is successfully written before a `poll_read` on a `Negotiated` stream,
but where the subsequent `poll_flush()` is pending.
Now `remaining` is empty and the next `poll_read()`
will go straight to reading from the underlying
I/O stream, despite the flush not having happened
yet, which can lead to a form of deadlock during
protocol negotiation.

Rather than complicating the existing code further in
order to accommodate for this case, it seems preferable
to simplify the code by giving up on this optimisation
that only affects the last negotiation protocol message
sent by the "listener". So we give up on the ability
to combine data sent by the "listener" immediately
after protocol negotiation together with the final
negotiation frame in the same transport-level frame/packet.

* Update changelog.

* Add missing comma.

2020-10-01 12:29:51 +02:00

..

core-derive

core-derive: use full qualified name when polling NetworkBehaviour (#1681)

2020-07-28 13:26:27 +02:00

multiaddr

Update unsigned-varint requirement from 0.4 to 0.5 (#1761)

2020-09-16 10:27:33 +02:00

multistream-select

[multistream-select] Require remaining negotiation data to be flushed. (#1781)

2020-10-01 12:29:51 +02:00

peer-id-generator

Prepare releases. (#1640)

2020-07-01 15:36:20 +02:00