fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-06-12 09:31:20 +00:00
Code Issues Projects Releases Wiki Activity

misc/multiaddr: Limit initial memory allocation in visit_seq (#1833)

Browse Source 
Without a limit, one can send malformed input such that seq.size_hint() returns
a very large value and crashes the program even if the following data is pretty
small.
This commit is contained in:
Pawan Dhananjay
2020-11-14 22:38:49 +05:30
committed by GitHub
parent 9c74b40870
commit f7ab4f7869
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
misc/multiaddr/src/lib.rs
View File

@ -346,7 +346,7 @@ impl<'de> Deserialize<'de> for Multiaddr {
formatter.write_str("multiaddress") formatter.write_str("multiaddress")
} }
fn visit_seq<A: de::SeqAccess<'de>>(self, mut seq: A) -> StdResult<Self::Value, A::Error> { fn visit_seq<A: de::SeqAccess<'de>>(self, mut seq: A) -> StdResult<Self::Value, A::Error> {
let mut buf: Vec<u8> = Vec::with_capacity(seq.size_hint().unwrap_or(0)); let mut buf: Vec<u8> = Vec::with_capacity(std::cmp::min(seq.size_hint().unwrap_or(0), 4096));
while let Some(e) = seq.next_element()? { buf.push(e); } while let Some(e) = seq.next_element()? { buf.push(e); }
if self.is_human_readable { if self.is_human_readable {
let s = String::from_utf8(buf).map_err(DeserializerError::custom)?; let s = String::from_utf8(buf).map_err(DeserializerError::custom)?;