fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-05-23 16:11:19 +00:00
Code Issues Projects Releases Wiki Activity

fix(ping): remove debug_assert on protocol negotiation timeout

Browse Source 
The negotiation of the ping protocol can timeout, thus a debug_assert is not correct. Return an `std::io::Error` instead.

Pull-Request: #3995.
This commit is contained in:
Max Inden 2023-05-30 05:21:52 +02:00 committed by GitHub
parent a8a00e7ad7
commit efb117e236
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
protocols/ping/src/handler.rs
View File

@ -196,10 +196,12 @@ impl Handler {
return; return;
} }
// Note: This timeout only covers protocol negotiation. // Note: This timeout only covers protocol negotiation.
StreamUpgradeError::Timeout => { StreamUpgradeError::Timeout => Failure::Other {
debug_assert!(false, "ReadyUpgrade cannot time out"); error: Box::new(std::io::Error::new(
return; std::io::ErrorKind::TimedOut,
} "ping protocol negotiation timed out",
)),
},
StreamUpgradeError::Apply(e) => void::unreachable(e), StreamUpgradeError::Apply(e) => void::unreachable(e),
StreamUpgradeError::Io(e) => Failure::Other { error: Box::new(e) }, StreamUpgradeError::Io(e) => Failure::Other { error: Box::new(e) },
}; };