fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-06-28 17:21:34 +00:00
Code Issues Projects Releases Wiki Activity

[libp2p-ping] Properly close the substream in the InboundUpgrade. (#1606)

Browse Source 
Not doing so may result in FIN/RST frames being sent before
earlier data frames. See https://github.com/paritytech/yamux/pull/81#issuecomment-643169973.
This commit is contained in:
Roman Borschel
2020-06-12 17:41:04 +02:00
committed by GitHub
parent 9aaf042410
commit e8bf34fcf1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
protocols/ping/src/protocol.rs
View File

@ -69,6 +69,7 @@ where
while let Ok(_) = socket.read_exact(&mut payload).await { while let Ok(_) = socket.read_exact(&mut payload).await {
socket.write_all(&payload).await?; socket.write_all(&payload).await?;
} }
socket.close().await?;
Ok(()) Ok(())
}.boxed() }.boxed()
} }
@ -128,7 +129,7 @@ mod tests {
} else { } else {
panic!("MemoryTransport not listening on an address!"); panic!("MemoryTransport not listening on an address!");
}; };
async_std::task::spawn(async move { async_std::task::spawn(async move {
let listener_event = listener.next().await.unwrap(); let listener_event = listener.next().await.unwrap();
let (listener_upgrade, _) = listener_event.unwrap().into_upgrade().unwrap(); let (listener_upgrade, _) = listener_event.unwrap().into_upgrade().unwrap();