mirror of
https://github.com/fluencelabs/rust-libp2p
synced 2025-06-15 02:51:25 +00:00
fix: Remove circular dependencies across workspace (#3023)
Circular dependencies are problematic in several ways: - They result in cognitive overhead for developers, in trying to figure out what depends on what. - They present `cargo` with limits in what order the crates can be compiled in. - They invalidate build caches unnecessarily thus forcing `cargo` to rebuild certain crates. - They cause problems with tooling such as `release-please`. To actually break the circular dependencies, this patch inlines the uses of `development_transport` in the examples and tests for all sub-crates. This is only meant to be a short-term fix until https://github.com/libp2p/rust-libp2p/issues/3111 and https://github.com/libp2p/rust-libp2p/pull/2888 are fixed. To ensure we don't accidentally reintroduce this dependency, we add a basic CI that queries `cargo metadata` using `jq`. Resolves https://github.com/libp2p/rust-libp2p/issues/3053. Fixes https://github.com/libp2p/rust-libp2p/issues/3223. Related: https://github.com/libp2p/rust-libp2p/pull/2918#discussion_r976514245 Related: https://github.com/googleapis/release-please/issues/1662
This commit is contained in:
@ -101,8 +101,8 @@
|
||||
//! // This is test transport (memory).
|
||||
//! let transport = MemoryTransport::default()
|
||||
//! .upgrade(libp2p_core::upgrade::Version::V1)
|
||||
//! .authenticate(libp2p::noise::NoiseAuthenticated::xx(&local_key).unwrap())
|
||||
//! .multiplex(libp2p::mplex::MplexConfig::new())
|
||||
//! .authenticate(libp2p_noise::NoiseAuthenticated::xx(&local_key).unwrap())
|
||||
//! .multiplex(libp2p_mplex::MplexConfig::new())
|
||||
//! .boxed();
|
||||
//!
|
||||
//! // Create a Gossipsub topic
|
||||
|
Reference in New Issue
Block a user