fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-04-25 19:02:13 +00:00
Code Issues Projects Releases Wiki Activity

Fix MultiHandler panicking when empty (#1598)

Browse Source
This commit is contained in:
Pierre Krieger 2020-06-05 11:48:53 +02:00 committed by GitHub
parent c76327e6b5
commit cacd7300de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
swarm/src/protocols_handler/multi.rs
View File

@ -157,6 +157,12 @@ where
fn poll(&mut self, cx: &mut Context) fn poll(&mut self, cx: &mut Context)
-> Poll<ProtocolsHandlerEvent<Self::OutboundProtocol, Self::OutboundOpenInfo, Self::OutEvent, Self::Error>> -> Poll<ProtocolsHandlerEvent<Self::OutboundProtocol, Self::OutboundOpenInfo, Self::OutEvent, Self::Error>>
{ {
// Calling `gen_range(0, 0)` (see below) would panic, so we have return early to avoid
// that situation.
if self.handlers.is_empty() {
return Poll::Pending;
}
// Not always polling handlers in the same order should give anyone the chance to make progress. // Not always polling handlers in the same order should give anyone the chance to make progress.
let pos = rand::thread_rng().gen_range(0, self.handlers.len()); let pos = rand::thread_rng().gen_range(0, self.handlers.len());