From 9d2df148cda888e4900ec72a8a750bce7815a34c Mon Sep 17 00:00:00 2001
From: Max Inden <mail@max-inden.de>
Date: Tue, 14 Jan 2020 18:19:10 +0100
Subject: [PATCH] core/src/transport/memory: Add basic dialer listener test
 (#1283)

* core/src/transport/memory: Add basic dialer listener test

Adds a basic test using two memory transport instances, one dialing the
other, sending a single message over the /wire/.

* core/src/nodes/network: Fix typo

* core/src/transport: Randomize listening port in unit test

* core/src/transport/memory: Update test to stable future

* core/src/transport/memory.rs: Use saturating_add for test port

Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com>

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Roman Borschel <romanb@users.noreply.github.com>
---
 core/src/nodes/network.rs    |  2 +-
 core/src/transport/memory.rs | 42 +++++++++++++++++++++++++++++++++++-
 2 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/core/src/nodes/network.rs b/core/src/nodes/network.rs
index db8630fe..0a92e901 100644
--- a/core/src/nodes/network.rs
+++ b/core/src/nodes/network.rs
@@ -70,7 +70,7 @@ where
     /// This needs to be a separate struct in order to handle multiple mutable borrows issues.
     reach_attempts: ReachAttempts<TPeerId>,
 
-    /// Max numer of incoming connections.
+    /// Max number of incoming connections.
     incoming_limit: Option<u32>,
 
     /// Unfinished take over message to be delivered.
diff --git a/core/src/transport/memory.rs b/core/src/transport/memory.rs
index 4fdbb47d..1fbc448e 100644
--- a/core/src/transport/memory.rs
+++ b/core/src/transport/memory.rs
@@ -279,6 +279,8 @@ impl<T: AsRef<[u8]>> Into<RwStreamSink<Chan<T>>> for Chan<T> {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use rand::Rng;
+    use std::io::Write;
 
     #[test]
     fn parse_memory_addr_works() {
@@ -311,5 +313,43 @@ mod tests {
         assert!(transport.dial("/memory/810172461024613".parse().unwrap()).is_ok());
     }
 
-    // TODO: test that is actually works
+    #[test]
+    fn communicating_between_dialer_and_listener() {
+        let msg = [1, 2, 3];
+
+        // Setup listener.
+
+        let rand_port = rand::random::<u64>().saturating_add(1);
+        let t1_addr: Multiaddr = format!("/memory/{}", rand_port).parse().unwrap();
+        let cloned_t1_addr = t1_addr.clone();
+
+        let t1 = MemoryTransport::default();
+
+        let listener = async move {
+            let listener = t1.listen_on(t1_addr.clone()).unwrap();
+
+            let upgrade = listener.filter_map(|ev| futures::future::ready(
+                ListenerEvent::into_upgrade(ev.unwrap())
+            )).next().await.unwrap();
+
+            let mut socket = upgrade.0.await.unwrap();
+
+            let mut buf = [0; 3];
+            socket.read_exact(&mut buf).await.unwrap();
+
+            assert_eq!(buf, msg);
+        };
+
+        // Setup dialer.
+
+        let t2 = MemoryTransport::default();
+        let dialer = async move {
+            let mut socket = t2.dial(cloned_t1_addr).unwrap().await.unwrap();
+            socket.write_all(&msg).await.unwrap();
+        };
+
+        // Wait for both to finish.
+
+        futures::executor::block_on(futures::future::join(listener, dialer));
+    }
 }