fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-06-29 09:41:34 +00:00
Code Issues Projects Releases Wiki Activity

Optimise Multiaddr::append. (#549)

Browse Source 
Append to the existing vector instead of allocating a temporary one and
copying bytes over.
This commit is contained in:
Toralf Wittner
2018-10-10 11:07:30 +02:00
committed by GitHub
parent fd4ae72f8c
commit 9bdaabc884
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
misc/multiaddr/src/lib.rs
View File

@ -24,6 +24,7 @@ use serde::{
};
use std::{
fmt,
io,
iter::FromIterator,
net::{SocketAddr, SocketAddrV4, SocketAddrV6, IpAddr, Ipv4Addr, Ipv6Addr},
result::Result as StdResult,
@ -180,9 +181,10 @@ impl Multiaddr {
///
#[inline]
pub fn append(&mut self, p: Protocol) {
let mut w = Vec::new();
p.write_bytes(&mut w).expect("writing to a Vec never fails");
self.bytes.extend_from_slice(&w);
let n = self.bytes.len();
let mut w = io::Cursor::new(&mut self.bytes);
w.set_position(n as u64);
p.write_bytes(&mut w).expect("writing to a Vec never fails")
}
/// Remove the outermost address.