feat(swarm)!: remove unused PendingConnectionError::Io variant (#3373)

This variant is never constructed.

misc/metrics/src/swarm.rs

@@ -364,7 +364,6 @@ enum PendingInboundConnectionError {
     TransportErrorMultiaddrNotSupported,
     TransportErrorOther,
     Aborted,
-    Io,
     ConnectionLimit,
 }
 
@@ -386,7 +385,6 @@ impl From<&libp2p_swarm::PendingInboundConnectionError> for PendingInboundConnec
             libp2p_swarm::PendingInboundConnectionError::Aborted => {
                 PendingInboundConnectionError::Aborted
             }
-            libp2p_swarm::PendingInboundConnectionError::IO(_) => PendingInboundConnectionError::Io,
         }
     }
 }

swarm/CHANGELOG.md

@@ -23,6 +23,10 @@
   If you have previously set `connection_event_buffer_size` you should re-evaluate what a good size for a _per connection_ buffer is.
   See [PR 3188].
 
+- Remove `PendingConnectionError:::IO` variant.
+  This was never constructed.
+  See [PR 3373].
+
 [PR 3364]: https://github.com/libp2p/rust-libp2p/pull/3364
 [PR 3170]: https://github.com/libp2p/rust-libp2p/pull/3170
 [PR 3134]: https://github.com/libp2p/rust-libp2p/pull/3134
@@ -31,6 +35,7 @@
 [PR 3272]: https://github.com/libp2p/rust-libp2p/pull/3272
 [PR 3327]: https://github.com/libp2p/rust-libp2p/pull/3327
 [PR 3188]: https://github.com/libp2p/rust-libp2p/pull/3188
+[PR 3373]: https://github.com/libp2p/rust-libp2p/pull/3373
 
 # 0.41.1
 

swarm/src/connection/error.rs

@@ -101,10 +101,6 @@ pub enum PendingConnectionError<TTransErr> {
         obtained: PeerId,
         endpoint: ConnectedPoint,
     },
-
-    /// An I/O error occurred on the connection.
-    // TODO: Eventually this should also be a custom error?
-    IO(io::Error),
 }
 
 impl<T> PendingConnectionError<T> {
@@ -118,7 +114,6 @@ impl<T> PendingConnectionError<T> {
             PendingConnectionError::WrongPeerId { obtained, endpoint } => {
                 PendingConnectionError::WrongPeerId { obtained, endpoint }
             }
-            PendingConnectionError::IO(e) => PendingConnectionError::IO(e),
         }
     }
 }
@@ -129,7 +124,6 @@ where
 {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            PendingConnectionError::IO(err) => write!(f, "Pending connection: I/O error: {err}"),
             PendingConnectionError::Aborted => write!(f, "Pending connection: Aborted."),
             PendingConnectionError::Transport(err) => {
                 write!(
@@ -156,7 +150,6 @@ where
 {
     fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
         match self {
-            PendingConnectionError::IO(err) => Some(err),
             PendingConnectionError::Transport(_) => None,
             PendingConnectionError::WrongPeerId { .. } => None,
             PendingConnectionError::Aborted => None,

swarm/src/lib.rs

@@ -1611,7 +1611,6 @@ impl From<PendingOutboundConnectionError> for DialError {
             PendingConnectionError::WrongPeerId { obtained, endpoint } => {
                 DialError::WrongPeerId { obtained, endpoint }
             }
-            PendingConnectionError::IO(e) => DialError::ConnectionIo(e),
             PendingConnectionError::Transport(e) => DialError::Transport(e),
         }
     }