fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-05-10 18:07:19 +00:00
Code Issues Projects Releases Wiki Activity

refactor(gossipsub): use pop instead of remove

Browse Source 
Doesn't change any functionality but `pop` returns an `Option` whereas `remove` will panic on out-of-bounds. I am more comfortable with `pop` and a pattern match. Also, usage of `continue` allows us to not use an `else`.

Pull-Request: #3734.
This commit is contained in:
Thomas Eizinger 2023-04-04 18:04:40 +02:00 committed by GitHub
parent 95fa913923
commit 7c85f92e31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
protocols/gossipsub/src/handler.rs
View File

@ -450,17 +450,17 @@ impl ConnectionHandler for Handler {
) { ) {
// outbound idle state // outbound idle state
Some(OutboundSubstreamState::WaitingOutput(substream)) => { Some(OutboundSubstreamState::WaitingOutput(substream)) => {
if !self.send_queue.is_empty() { if let Some(message) = self.send_queue.pop() {
let message = self.send_queue.remove(0);
self.send_queue.shrink_to_fit(); self.send_queue.shrink_to_fit();
self.outbound_substream = self.outbound_substream =
Some(OutboundSubstreamState::PendingSend(substream, message)); Some(OutboundSubstreamState::PendingSend(substream, message));
} else { continue;
}
self.outbound_substream = self.outbound_substream =
Some(OutboundSubstreamState::WaitingOutput(substream)); Some(OutboundSubstreamState::WaitingOutput(substream));
break; break;
} }
}
Some(OutboundSubstreamState::PendingSend(mut substream, message)) => { Some(OutboundSubstreamState::PendingSend(mut substream, message)) => {
match Sink::poll_ready(Pin::new(&mut substream), cx) { match Sink::poll_ready(Pin::new(&mut substream), cx) {
Poll::Ready(Ok(())) => { Poll::Ready(Ok(())) => {