From 7c108b66f22b06d8df9ecb5095dbe77fea4da8c5 Mon Sep 17 00:00:00 2001
From: Pierre Krieger <pierre.krieger1708@gmail.com>
Date: Thu, 23 May 2019 15:16:46 +0200
Subject: [PATCH] Fix small todo in handled tasks (#1114)

* Fix small todo in handled tasks

* Address review
---
 core/src/nodes/handled_node_tasks.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/core/src/nodes/handled_node_tasks.rs b/core/src/nodes/handled_node_tasks.rs
index 4079b351..fb8fe3ed 100644
--- a/core/src/nodes/handled_node_tasks.rs
+++ b/core/src/nodes/handled_node_tasks.rs
@@ -335,9 +335,12 @@ impl<TInEvent, TOutEvent, TIntoHandler, TReachErr, THandlerErr, TUserData, TConn
         for n in (0..self.local_spawns.len()).rev() {
             let mut task = self.local_spawns.swap_remove(n);
             match task.poll() {
-                Ok(Async::Ready(())) => (),
+                Ok(Async::Ready(())) => {},
                 Ok(Async::NotReady) => self.local_spawns.push(task),
-                Err(_err) => ()     // TODO: log this?
+                // It would normally be desirable to either report or log when a background task
+                // errors. However the default tokio executor doesn't do anything in case of error,
+                // and therefore we mimic this behaviour by also not doing anything.
+                Err(()) => {}
             }
         }