Simple Warning Cleanup (#1278)

* Cleaning up warnings - removing unused `use`

* Cleaning up warnings - unused tuple value

* Cleaning up warnings - removing dead code

* Cleaning up warnings - fixing deprecated name

* Cleaning up warnings - removing dead code

* Revert "Cleaning up warnings - removing dead code"

This reverts commit f18a765e4bf240b0ed9294ec3ae5dab5c186b801.

core/src/identity/rsa.rs

@@ -27,7 +27,6 @@ use ring::rand::SystemRandom;
 use ring::signature::{self, RsaKeyPair, RSA_PKCS1_SHA256, RSA_PKCS1_2048_8192_SHA256};
 use ring::signature::KeyPair;
 use std::sync::Arc;
-use untrusted::Input;
 use zeroize::Zeroize;
 
 /// An RSA keypair.

core/src/nodes/listeners.rs

@@ -408,7 +408,7 @@ mod tests {
             .map_err(|(err, _)| err);
 
         let mut runtime = Runtime::new().unwrap();
-        runtime.block_on(future).unwrap();
+        let _ = runtime.block_on(future).unwrap();
     }
 
     #[test]

core/src/peer_id.rs

@@ -219,7 +219,7 @@ impl Into<multihash::Multihash> for PeerId {
 quick_error! {
     #[derive(Debug)]
     pub enum ParseError {
-        B58(e: bs58::decode::DecodeError) {
+        B58(e: bs58::decode::Error) {
             display("base-58 decode error: {}", e)
             cause(e)
             from()

misc/multiaddr/src/errors.rs

@@ -57,8 +57,8 @@ impl From<multihash::DecodeOwnedError> for Error {
     }
 }
 
-impl From<bs58::decode::DecodeError> for Error {
-    fn from(err: bs58::decode::DecodeError) -> Error {
+impl From<bs58::decode::Error> for Error {
+    fn from(err: bs58::decode::Error) -> Error {
         Error::ParsingError(err.into())
     }
 }

protocols/secio/src/exchange/impl_ring.rs

@@ -25,7 +25,6 @@ use futures::{future, prelude::*};
 use log::debug;
 use ring::agreement as ring_agreement;
 use ring::rand as ring_rand;
-use untrusted::Input as UntrustedInput;
 
 impl Into<&'static ring_agreement::Algorithm> for KeyAgreement {
     #[inline]