fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-05-03 06:32:16 +00:00
Code Issues Projects Releases Wiki Activity

Address review on stable-futures

Browse Source
This commit is contained in:
Pierre Krieger 2020-01-06 14:08:02 +01:00
parent 84ebd20d01
commit 65a7de49b2
No known key found for this signature in database
GPG Key ID: EE749C4F41D4EA47
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/nodes/tasks/manager.rs
View File

@ -67,7 +67,7 @@ pub struct Manager<I, O, H, E, HE, T, C = PeerId> {
/// `local_spawns` list instead. /// `local_spawns` list instead.
threads_pool: Option<ThreadPool>, threads_pool: Option<ThreadPool>,
/// If no executor is available, we move tasks to this list, and futures are polled on the /// If no executor is available, we move tasks to this set, and futures are polled on the
/// current thread instead. /// current thread instead.
local_spawns: FuturesUnordered<Pin<Box<dyn Future<Output = ()> + Send>>>, local_spawns: FuturesUnordered<Pin<Box<dyn Future<Output = ()> + Send>>>,
@ -237,7 +237,12 @@ impl<I, O, H, E, HE, T, C> Manager<I, O, H, E, HE, T, C> {
let msg = ToTaskMessage::HandlerEvent(event.clone()); let msg = ToTaskMessage::HandlerEvent(event.clone());
match task.sender.start_send(msg) { match task.sender.start_send(msg) {
Ok(()) => {}, Ok(()) => {},
Err(ref err) if err.is_full() => {}, // TODO: somehow report to user? Err(ref err) if err.is_full() => {
// Note that the user is expected to call `poll_ready_broadcast` beforehand,
// which returns `Poll::Ready` only if the channel isn't full. Reaching this
// path always indicates a mistake in the code.
log::warn!("start_broadcast called while channel was full");
},
Err(_) => {}, Err(_) => {},
} }
} }