fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-06-30 02:01:35 +00:00
Code Issues Projects Releases Wiki Activity

refactor(identity): fix clippy beta lint

Browse Source 
From the lint documentation:

> If both `PartialOrd` and `Ord` are implemented, they must agree. This is commonly done by wrapping the result of `cmp` in `Some` for `partial_cmp`. Not doing this may silently introduce an error upon refactoring.

Pull-Request: #4379.
This commit is contained in:
Thomas Eizinger
2023-08-24 08:01:19 +02:00
committed by GitHub
parent 54fa53af39
commit 3bce9ebddf
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
identity/src/ed25519.rs
View File

@ -128,7 +128,7 @@ impl hash::Hash for PublicKey {
impl cmp::PartialOrd for PublicKey { impl cmp::PartialOrd for PublicKey {
fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> { fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
self.0.as_bytes().partial_cmp(other.0.as_bytes()) Some(self.cmp(other))
} }
} }

2
identity/src/secp256k1.rs
View File

@ -178,7 +178,7 @@ impl hash::Hash for PublicKey {
impl cmp::PartialOrd for PublicKey { impl cmp::PartialOrd for PublicKey {
fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> { fn partial_cmp(&self, other: &Self) -> Option<cmp::Ordering> {
self.to_bytes().partial_cmp(&other.to_bytes()) Some(self.cmp(other))
} }
} }