chore: enforce unreachable_pub lint

The `unreachable_pub` lint makes us aware of uses of `pub` that are not actually reachable from the crate root. This is considered good because it means reading a `pub` somewhere means it is actually public API. Some of our crates are quite large and keeping their entire API surface in your head is difficult.

We should strive for most items being `pub(crate)`. This lint helps us enforce that.

Pull-Request: #3735.
This commit is contained in:
Thomas Eizinger
2023-04-26 09:31:56 +02:00
committed by GitHub
parent e5dbeb3e08
commit 135942d319
93 changed files with 861 additions and 767 deletions

View File

@ -26,7 +26,7 @@ use crate::{client, server};
const BUF: [u8; 1024] = [0; 1024];
pub async fn send_receive<S: AsyncRead + AsyncWrite + Unpin>(
pub(crate) async fn send_receive<S: AsyncRead + AsyncWrite + Unpin>(
params: client::RunParams,
mut stream: S,
) -> Result<client::RunTimers, std::io::Error> {
@ -67,7 +67,7 @@ pub async fn send_receive<S: AsyncRead + AsyncWrite + Unpin>(
})
}
pub async fn receive_send<S: AsyncRead + AsyncWrite + Unpin>(
pub(crate) async fn receive_send<S: AsyncRead + AsyncWrite + Unpin>(
mut stream: S,
) -> Result<server::RunStats, std::io::Error> {
let to_send = {