mirror of
https://github.com/fluencelabs/redis
synced 2025-06-26 23:41:33 +00:00
lookupKeyByPattern() was implemented with a trick to speedup the lookup process allocating two fake Redis obejcts on the stack. However now that we propagate expires to the slave as DEL operations the lookup of the key may result into a call to expireIfNeeded() having the stack allocated object as argument, that may in turn use it to create the protocol to send to the slave. But since this fake obejcts are inherently read-only this is a problem. As a side effect of this fix there are no longer size limits in the pattern to be used with GET/BY option of SORT. See https://github.com/antirez/redis/issues/460 for bug details.
399 lines
14 KiB
C
399 lines
14 KiB
C
#include "redis.h"
|
|
#include "pqsort.h" /* Partial qsort for SORT+LIMIT */
|
|
|
|
redisSortOperation *createSortOperation(int type, robj *pattern) {
|
|
redisSortOperation *so = zmalloc(sizeof(*so));
|
|
so->type = type;
|
|
so->pattern = pattern;
|
|
return so;
|
|
}
|
|
|
|
/* Return the value associated to the key with a name obtained using
|
|
* the following rules:
|
|
*
|
|
* 1) The first occurence of '*' in 'pattern' is substituted with 'subst'.
|
|
*
|
|
* 2) If 'pattern' matches the "->" string, everything on the left of
|
|
* the arrow is treated as the name of an hash field, and the part on the
|
|
* left as the key name containing an hash. The value of the specified
|
|
* field is returned.
|
|
*
|
|
* 3) If 'pattern' equals "#", the function simply returns 'subst' itself so
|
|
* that the SORT command can be used like: SORT key GET # to retrieve
|
|
* the Set/List elements directly.
|
|
*
|
|
* The returned object will always have its refcount increased by 1
|
|
* when it is non-NULL. */
|
|
robj *lookupKeyByPattern(redisDb *db, robj *pattern, robj *subst) {
|
|
char *p, *f, *k;
|
|
sds spat, ssub;
|
|
robj *keyobj, *fieldobj, *o;
|
|
int prefixlen, sublen, postfixlen, fieldlen;
|
|
|
|
/* If the pattern is "#" return the substitution object itself in order
|
|
* to implement the "SORT ... GET #" feature. */
|
|
spat = pattern->ptr;
|
|
if (spat[0] == '#' && spat[1] == '\0') {
|
|
incrRefCount(subst);
|
|
return subst;
|
|
}
|
|
|
|
/* The substitution object may be specially encoded. If so we create
|
|
* a decoded object on the fly. Otherwise getDecodedObject will just
|
|
* increment the ref count, that we'll decrement later. */
|
|
subst = getDecodedObject(subst);
|
|
ssub = subst->ptr;
|
|
|
|
/* If we can't find '*' in the pattern we return NULL as to GET a
|
|
* fixed key does not make sense. */
|
|
p = strchr(spat,'*');
|
|
if (!p) {
|
|
decrRefCount(subst);
|
|
return NULL;
|
|
}
|
|
|
|
/* Find out if we're dealing with a hash dereference. */
|
|
if ((f = strstr(p+1, "->")) != NULL && *(f+2) != '\0') {
|
|
fieldlen = sdslen(spat)-(f-spat)-2;
|
|
fieldobj = createStringObject(f+2,fieldlen);
|
|
} else {
|
|
fieldlen = 0;
|
|
}
|
|
|
|
/* Perform the '*' substitution. */
|
|
prefixlen = p-spat;
|
|
sublen = sdslen(ssub);
|
|
postfixlen = sdslen(spat)-(prefixlen+1)-(fieldlen ? fieldlen+2 : 0);
|
|
keyobj = createStringObject(NULL,prefixlen+sublen+postfixlen);
|
|
k = keyobj->ptr;
|
|
memcpy(k,spat,prefixlen);
|
|
memcpy(k+prefixlen,ssub,sublen);
|
|
memcpy(k+prefixlen+sublen,p+1,postfixlen);
|
|
decrRefCount(subst); /* Incremented by decodeObject() */
|
|
|
|
/* Lookup substituted key */
|
|
o = lookupKeyRead(db,keyobj);
|
|
if (o == NULL) goto noobj;
|
|
|
|
if (fieldlen > 0) {
|
|
if (o->type != REDIS_HASH) goto noobj;
|
|
|
|
/* Retrieve value from hash by the field name. This operation
|
|
* already increases the refcount of the returned object. */
|
|
o = hashTypeGetObject(o, fieldobj);
|
|
} else {
|
|
if (o->type != REDIS_STRING) goto noobj;
|
|
|
|
/* Every object that this function returns needs to have its refcount
|
|
* increased. sortCommand decreases it again. */
|
|
incrRefCount(o);
|
|
}
|
|
decrRefCount(keyobj);
|
|
if (fieldlen) decrRefCount(fieldobj);
|
|
return o;
|
|
|
|
noobj:
|
|
decrRefCount(keyobj);
|
|
if (fieldlen) decrRefCount(fieldobj);
|
|
return NULL;
|
|
}
|
|
|
|
/* sortCompare() is used by qsort in sortCommand(). Given that qsort_r with
|
|
* the additional parameter is not standard but a BSD-specific we have to
|
|
* pass sorting parameters via the global 'server' structure */
|
|
int sortCompare(const void *s1, const void *s2) {
|
|
const redisSortObject *so1 = s1, *so2 = s2;
|
|
int cmp;
|
|
|
|
if (!server.sort_alpha) {
|
|
/* Numeric sorting. Here it's trivial as we precomputed scores */
|
|
if (so1->u.score > so2->u.score) {
|
|
cmp = 1;
|
|
} else if (so1->u.score < so2->u.score) {
|
|
cmp = -1;
|
|
} else {
|
|
cmp = 0;
|
|
}
|
|
} else {
|
|
/* Alphanumeric sorting */
|
|
if (server.sort_bypattern) {
|
|
if (!so1->u.cmpobj || !so2->u.cmpobj) {
|
|
/* At least one compare object is NULL */
|
|
if (so1->u.cmpobj == so2->u.cmpobj)
|
|
cmp = 0;
|
|
else if (so1->u.cmpobj == NULL)
|
|
cmp = -1;
|
|
else
|
|
cmp = 1;
|
|
} else {
|
|
/* We have both the objects, use strcoll */
|
|
cmp = strcoll(so1->u.cmpobj->ptr,so2->u.cmpobj->ptr);
|
|
}
|
|
} else {
|
|
/* Compare elements directly. */
|
|
cmp = compareStringObjects(so1->obj,so2->obj);
|
|
}
|
|
}
|
|
return server.sort_desc ? -cmp : cmp;
|
|
}
|
|
|
|
/* The SORT command is the most complex command in Redis. Warning: this code
|
|
* is optimized for speed and a bit less for readability */
|
|
void sortCommand(redisClient *c) {
|
|
list *operations;
|
|
unsigned int outputlen = 0;
|
|
int desc = 0, alpha = 0;
|
|
int limit_start = 0, limit_count = -1, start, end;
|
|
int j, dontsort = 0, vectorlen;
|
|
int getop = 0; /* GET operation counter */
|
|
robj *sortval, *sortby = NULL, *storekey = NULL;
|
|
redisSortObject *vector; /* Resulting vector to sort */
|
|
|
|
/* Lookup the key to sort. It must be of the right types */
|
|
sortval = lookupKeyRead(c->db,c->argv[1]);
|
|
if (sortval && sortval->type != REDIS_SET && sortval->type != REDIS_LIST &&
|
|
sortval->type != REDIS_ZSET)
|
|
{
|
|
addReply(c,shared.wrongtypeerr);
|
|
return;
|
|
}
|
|
|
|
/* Create a list of operations to perform for every sorted element.
|
|
* Operations can be GET/DEL/INCR/DECR */
|
|
operations = listCreate();
|
|
listSetFreeMethod(operations,zfree);
|
|
j = 2;
|
|
|
|
/* Now we need to protect sortval incrementing its count, in the future
|
|
* SORT may have options able to overwrite/delete keys during the sorting
|
|
* and the sorted key itself may get destroied */
|
|
if (sortval)
|
|
incrRefCount(sortval);
|
|
else
|
|
sortval = createListObject();
|
|
|
|
/* The SORT command has an SQL-alike syntax, parse it */
|
|
while(j < c->argc) {
|
|
int leftargs = c->argc-j-1;
|
|
if (!strcasecmp(c->argv[j]->ptr,"asc")) {
|
|
desc = 0;
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"desc")) {
|
|
desc = 1;
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"alpha")) {
|
|
alpha = 1;
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"limit") && leftargs >= 2) {
|
|
limit_start = atoi(c->argv[j+1]->ptr);
|
|
limit_count = atoi(c->argv[j+2]->ptr);
|
|
j+=2;
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"store") && leftargs >= 1) {
|
|
storekey = c->argv[j+1];
|
|
j++;
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"by") && leftargs >= 1) {
|
|
sortby = c->argv[j+1];
|
|
/* If the BY pattern does not contain '*', i.e. it is constant,
|
|
* we don't need to sort nor to lookup the weight keys. */
|
|
if (strchr(c->argv[j+1]->ptr,'*') == NULL) dontsort = 1;
|
|
j++;
|
|
} else if (!strcasecmp(c->argv[j]->ptr,"get") && leftargs >= 1) {
|
|
listAddNodeTail(operations,createSortOperation(
|
|
REDIS_SORT_GET,c->argv[j+1]));
|
|
getop++;
|
|
j++;
|
|
} else {
|
|
decrRefCount(sortval);
|
|
listRelease(operations);
|
|
addReply(c,shared.syntaxerr);
|
|
return;
|
|
}
|
|
j++;
|
|
}
|
|
|
|
/* Destructively convert encoded sorted sets for SORT. */
|
|
if (sortval->type == REDIS_ZSET)
|
|
zsetConvert(sortval, REDIS_ENCODING_SKIPLIST);
|
|
|
|
/* Load the sorting vector with all the objects to sort */
|
|
switch(sortval->type) {
|
|
case REDIS_LIST: vectorlen = listTypeLength(sortval); break;
|
|
case REDIS_SET: vectorlen = setTypeSize(sortval); break;
|
|
case REDIS_ZSET: vectorlen = dictSize(((zset*)sortval->ptr)->dict); break;
|
|
default: vectorlen = 0; redisPanic("Bad SORT type"); /* Avoid GCC warning */
|
|
}
|
|
vector = zmalloc(sizeof(redisSortObject)*vectorlen);
|
|
j = 0;
|
|
|
|
if (sortval->type == REDIS_LIST) {
|
|
listTypeIterator *li = listTypeInitIterator(sortval,0,REDIS_TAIL);
|
|
listTypeEntry entry;
|
|
while(listTypeNext(li,&entry)) {
|
|
vector[j].obj = listTypeGet(&entry);
|
|
vector[j].u.score = 0;
|
|
vector[j].u.cmpobj = NULL;
|
|
j++;
|
|
}
|
|
listTypeReleaseIterator(li);
|
|
} else if (sortval->type == REDIS_SET) {
|
|
setTypeIterator *si = setTypeInitIterator(sortval);
|
|
robj *ele;
|
|
while((ele = setTypeNextObject(si)) != NULL) {
|
|
vector[j].obj = ele;
|
|
vector[j].u.score = 0;
|
|
vector[j].u.cmpobj = NULL;
|
|
j++;
|
|
}
|
|
setTypeReleaseIterator(si);
|
|
} else if (sortval->type == REDIS_ZSET) {
|
|
dict *set = ((zset*)sortval->ptr)->dict;
|
|
dictIterator *di;
|
|
dictEntry *setele;
|
|
di = dictGetIterator(set);
|
|
while((setele = dictNext(di)) != NULL) {
|
|
vector[j].obj = dictGetEntryKey(setele);
|
|
vector[j].u.score = 0;
|
|
vector[j].u.cmpobj = NULL;
|
|
j++;
|
|
}
|
|
dictReleaseIterator(di);
|
|
} else {
|
|
redisPanic("Unknown type");
|
|
}
|
|
redisAssert(j == vectorlen);
|
|
|
|
/* Now it's time to load the right scores in the sorting vector */
|
|
if (dontsort == 0) {
|
|
for (j = 0; j < vectorlen; j++) {
|
|
robj *byval;
|
|
if (sortby) {
|
|
/* lookup value to sort by */
|
|
byval = lookupKeyByPattern(c->db,sortby,vector[j].obj);
|
|
if (!byval) continue;
|
|
} else {
|
|
/* use object itself to sort by */
|
|
byval = vector[j].obj;
|
|
}
|
|
|
|
if (alpha) {
|
|
if (sortby) vector[j].u.cmpobj = getDecodedObject(byval);
|
|
} else {
|
|
if (byval->encoding == REDIS_ENCODING_RAW) {
|
|
vector[j].u.score = strtod(byval->ptr,NULL);
|
|
} else if (byval->encoding == REDIS_ENCODING_INT) {
|
|
/* Don't need to decode the object if it's
|
|
* integer-encoded (the only encoding supported) so
|
|
* far. We can just cast it */
|
|
vector[j].u.score = (long)byval->ptr;
|
|
} else {
|
|
redisAssert(1 != 1);
|
|
}
|
|
}
|
|
|
|
/* when the object was retrieved using lookupKeyByPattern,
|
|
* its refcount needs to be decreased. */
|
|
if (sortby) {
|
|
decrRefCount(byval);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* We are ready to sort the vector... perform a bit of sanity check
|
|
* on the LIMIT option too. We'll use a partial version of quicksort. */
|
|
start = (limit_start < 0) ? 0 : limit_start;
|
|
end = (limit_count < 0) ? vectorlen-1 : start+limit_count-1;
|
|
if (start >= vectorlen) {
|
|
start = vectorlen-1;
|
|
end = vectorlen-2;
|
|
}
|
|
if (end >= vectorlen) end = vectorlen-1;
|
|
|
|
if (dontsort == 0) {
|
|
server.sort_desc = desc;
|
|
server.sort_alpha = alpha;
|
|
server.sort_bypattern = sortby ? 1 : 0;
|
|
if (sortby && (start != 0 || end != vectorlen-1))
|
|
pqsort(vector,vectorlen,sizeof(redisSortObject),sortCompare, start,end);
|
|
else
|
|
qsort(vector,vectorlen,sizeof(redisSortObject),sortCompare);
|
|
}
|
|
|
|
/* Send command output to the output buffer, performing the specified
|
|
* GET/DEL/INCR/DECR operations if any. */
|
|
outputlen = getop ? getop*(end-start+1) : end-start+1;
|
|
if (storekey == NULL) {
|
|
/* STORE option not specified, sent the sorting result to client */
|
|
addReplyMultiBulkLen(c,outputlen);
|
|
for (j = start; j <= end; j++) {
|
|
listNode *ln;
|
|
listIter li;
|
|
|
|
if (!getop) addReplyBulk(c,vector[j].obj);
|
|
listRewind(operations,&li);
|
|
while((ln = listNext(&li))) {
|
|
redisSortOperation *sop = ln->value;
|
|
robj *val = lookupKeyByPattern(c->db,sop->pattern,
|
|
vector[j].obj);
|
|
|
|
if (sop->type == REDIS_SORT_GET) {
|
|
if (!val) {
|
|
addReply(c,shared.nullbulk);
|
|
} else {
|
|
addReplyBulk(c,val);
|
|
decrRefCount(val);
|
|
}
|
|
} else {
|
|
redisAssert(sop->type == REDIS_SORT_GET); /* always fails */
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
robj *sobj = createZiplistObject();
|
|
|
|
/* STORE option specified, set the sorting result as a List object */
|
|
for (j = start; j <= end; j++) {
|
|
listNode *ln;
|
|
listIter li;
|
|
|
|
if (!getop) {
|
|
listTypePush(sobj,vector[j].obj,REDIS_TAIL);
|
|
} else {
|
|
listRewind(operations,&li);
|
|
while((ln = listNext(&li))) {
|
|
redisSortOperation *sop = ln->value;
|
|
robj *val = lookupKeyByPattern(c->db,sop->pattern,
|
|
vector[j].obj);
|
|
|
|
if (sop->type == REDIS_SORT_GET) {
|
|
if (!val) val = createStringObject("",0);
|
|
|
|
/* listTypePush does an incrRefCount, so we should take care
|
|
* care of the incremented refcount caused by either
|
|
* lookupKeyByPattern or createStringObject("",0) */
|
|
listTypePush(sobj,val,REDIS_TAIL);
|
|
decrRefCount(val);
|
|
} else {
|
|
/* always fails */
|
|
redisAssert(sop->type == REDIS_SORT_GET);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
if (outputlen) setKey(c->db,storekey,sobj);
|
|
decrRefCount(sobj);
|
|
server.dirty += outputlen;
|
|
addReplyLongLong(c,outputlen);
|
|
}
|
|
|
|
/* Cleanup */
|
|
if (sortval->type == REDIS_LIST || sortval->type == REDIS_SET)
|
|
for (j = 0; j < vectorlen; j++)
|
|
decrRefCount(vector[j].obj);
|
|
decrRefCount(sortval);
|
|
listRelease(operations);
|
|
for (j = 0; j < vectorlen; j++) {
|
|
if (alpha && vector[j].u.cmpobj)
|
|
decrRefCount(vector[j].u.cmpobj);
|
|
}
|
|
zfree(vector);
|
|
}
|
|
|
|
|