6fbcb19275
luaRedisGenericCommand() cached argv handling simplified.
...
As discussed in issue #1945 .
2014-09-10 15:47:02 +02:00
8375a6d0aa
Limit the *SCAN command dictScan iterations
...
*SCAN will cause redis server to hang for seconds
after millions of keys was deleted by SCAN/DEL pairs
2014-09-10 09:58:20 +02:00
55024e9a9a
Sentinel: don't set announce-ip if is empty.
2014-09-10 09:26:29 +02:00
3cc31da349
Sentinel: clarify announce-ip/port options in sentinel.conf.
2014-09-10 09:26:29 +02:00
8c3507aa8f
Sentinel: announce ip/port changes + rewrite.
...
The original implementation was modified in order to allow to
selectively announce a different IP or port, and to rewrite the two
options in the config file after a rewrite.
2014-09-10 09:26:29 +02:00
9f3abf436b
sentinel: Decouple bind address from address sent to other sentinels
...
There are instances such as EC2 where the bind address is private
(behind a NAT) and cannot be accessible from WAN.
https://groups.google.com/d/msg/redis-db/PVVvjO4nMd0/P3oWC036v3cJ
2014-09-10 09:26:29 +02:00
ff47d5ebf6
Tests for aof-load-truncated = yes.
2014-09-08 10:58:00 +02:00
b3fdddfd1f
AOF tests fixed turning aof-load-truncated to no.
...
When aof-load-truncated option was introduced, with a default of "yes",
the past behavior of the server to abort with trunncated AOF changed, so
we need to explicitly configure the tests to abort with truncated AOF
by setting the option to no.
2014-09-08 10:58:00 +02:00
670084b724
Make aof-load-truncated option actually configurable.
2014-09-08 10:58:00 +02:00
03a5c0ecb5
Correct cleanup when aborting AOF loading.
...
Because of the new ability to start with a truncated AOF, we need
to correctly release all the memory on EOF error. Otherwise there is a
small leak, that is not really a problem, but causes a false positive in
the tests that detect memory leaks.
2014-09-08 10:58:00 +02:00
683cf5b872
AOF ability to load truncated files.
2014-09-08 10:57:57 +02:00
94f7979414
Test AOF format error detection.
2014-09-08 10:57:11 +02:00
537f3053fa
AOF loading: split handling of format errors from unexpected EOF.
2014-09-08 10:57:10 +02:00
667e2991dc
Return empty string if GETRANGE of empty string
...
Previously, GETRANGE of a key containing nothing ("")
would allocate a large (size_t)-1 return value causing
crashes on 32bit builds when it tried to allocate the
4 GB return string.
2014-09-04 11:47:21 +02:00
4284b07220
Increase size of range request in getrange
...
32 bit builds don't have a big enough long to capture
the same range as a 64 bit build. If we use "long long"
we get proper size limits everywhere.
Also updates size of unsigned comparison to fit new size of `end`.
Fixes #1981
2014-09-04 11:46:57 +02:00
db6e874a25
Redis 2.8.14.
2014-09-01 17:00:38 +02:00
dd36f18c76
Sentinel: Abort Hello quicker if not connected
...
We can save a little work by aborting when we enter the function
if we're disconnected.
2014-09-01 16:35:04 +02:00
d1f89bdc2b
Add regression test for issue #1939
2014-09-01 10:41:15 +02:00
59ad68ca4f
Store the length of the static argv when first allocated.
2014-09-01 10:40:04 +02:00
8fb8a474fd
Fix dictRehash assert casting type.
...
Also related to #1929 .
2014-08-27 10:31:52 +02:00
85b3db4065
Cast to right type in dictNext().
...
This closes issue #1929 , the other part was fixed in the context of issue
2014-08-27 10:31:48 +02:00
3a706ba792
Use long for rehash and iterator index in dict.h.
...
This allows to support datasets with more than 2 billion of keys
(possible in very large memory instances, this bug was actually
reported).
Closes issue #1814 .
2014-08-27 10:31:44 +02:00
97fdcd8746
Missing va_end also added in hiredis copy of sds.c.
2014-08-27 10:31:41 +02:00
45fac9481a
Missing assert removal from sdsIncrLen()
...
Companion for 8eeb1802ec
2014-08-27 10:31:35 +02:00
c3eac3ddff
No longer useful assert removed from sdsIncrLen().
2014-08-27 10:31:32 +02:00
fdcadd16c6
Fix redis-benchmark abort output
2014-08-27 10:31:29 +02:00
ac48aada30
Deny CLIENT command in scripts
...
We don't want scripts doing CLIENT SETNAME
or CLIENT KILL or CLIENT LIST or CLIENT PAUSE.
Originally reported by Chris Wj then proper
action inspired by Itamar Haber.
Reference: https://groups.google.com/forum/#!topic/redis-db/09B2EYwyVgk
2014-08-27 10:31:20 +02:00
abe29c83e6
redis-benchmark: Remove unused buffer
...
This just deletes old code that didn't get removed when
logic changed. We were setting offsets that never
got read anywhere.
Since clients are now just cloned, we don't need to track
per-client buffer offsets anywhere because they are all
the same from the original client.
2014-08-27 10:30:49 +02:00
8fcce90b25
redis-benchmark: add auth option
...
Closes #1097
2014-08-27 10:30:49 +02:00
4ac8472cac
Rename two 'buf' vars to 'ip' for better clarity
...
Clearly ip[32] is wrong, but it's less clear that buf[32] was wrong
without further reading.
2014-08-27 10:30:42 +02:00
f7b5e2d11e
Sentinel: fix bufsize to support IPv6 address
...
Closes #1914
2014-08-27 10:30:37 +02:00
32a94beca4
Use correct github url to find commands.json
...
Once this is merged:
- merge the latest changes to commands.json in antirez/redis-doc
- re-run: utils/generate-command-help.rb > src/help.h
Then we'll have nice and easy tab-completed help in redis-cli again.
Closes #1909
2014-08-27 10:30:34 +02:00
f862e5ddfa
Stop tests from leaving a black background
...
Uses ANSI "default background" color code after closing tests
so any non-black terminals don't remain polluted.
Fixes #1649
Closes #1912
2014-08-27 10:30:29 +02:00
32168a5e8a
Sentinel: Reject config from STDIN
...
Sentinel needs to die with a more accurate error message
when attempted to open a config from STDIN.
See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
2014-08-27 10:30:26 +02:00
4bf7c5d0f8
Remove unused global variable
...
It has an important name, but nothing uses it...
2014-08-27 10:30:22 +02:00
33b37b1400
Fix invalid expire error for SET family commands.
2014-08-27 10:30:19 +02:00
ae2cd2e16f
Remove unused function
...
Closes #878
2014-08-27 10:30:11 +02:00
8c0743d80e
Extend range of bytesToHuman to TB and PB
...
Also adds a fallthrough case for when given
large values (like overflow numbers of 2^64 by mistake).
Closes #858
2014-08-27 10:30:08 +02:00
ef12b4c3eb
Add error check for writing RDB checksum
...
Closes #857
2014-08-27 10:30:04 +02:00
1580a378b8
redis-cli: fix prompt after shutdown command
...
Fix redis-cli prompt to state "not connected" after a SHUTDOWN command
is sent.
2014-08-27 10:30:01 +02:00
467848460a
Clarify argument to dict macro
...
d is more clear because the type of argument is dict not dictht
Closes #513
2014-08-27 10:29:57 +02:00
5e707c66dd
Fix undefined behavior in ll2string().
...
The bug was found by @CAFxX, thanks!
See issue #1940 .
2014-08-27 10:29:53 +02:00
65d47452f8
Remove warnings and improve integer sign correctness.
2014-08-27 10:29:26 +02:00
09757420a4
Add -W to compilation flags.
2014-08-27 10:25:57 +02:00
134345e332
Use unsigned integers in SDS header.
...
This raises the max string to 4GB without any downside.
2014-08-27 10:25:54 +02:00
f89a7bbe11
va_copy must be matched by va_end
...
Hat tip to @rfuchs. See: https://github.com/redis/hiredis/pull/178 .
Fixes #1187
2014-08-27 10:25:44 +02:00
dbcf381099
Remove duplicate prototypes in redis.h
...
Also moves acceptHandler() to be near the other accept...() functions.
Closes #1105
2014-08-27 10:25:40 +02:00
6bc74b4393
Use resolv library in Solaris
...
For some Solaris flavours, the inet_aton in in resolv library.
Not linking this library will introduce link error.
Improves compatability with older Solaris and still
works on new Solaris.
Closes #1092
2014-08-27 10:25:37 +02:00
1aff711d90
Define AR to help with lua cross-compilation
...
Closes #997
2014-08-27 10:25:34 +02:00
866f6bcc80
Cleanup double semicolons
...
Closes #1161
2014-08-27 10:25:31 +02:00
