a17bddf2a1
fix maxmemory config warning
...
the warning condition was if usage > limit (saying it'll cause eviction
or oom), but in fact the eviction and oom depends on used minus slave
buffers.
other than fixing the condition, i add info about the current usage and
limit, which may be useful when looking at the log.
2020-02-06 09:23:22 +02:00
7e1d5954e5
Memory leak when bind config is provided twice
2020-02-06 09:17:39 +02:00
ac2c96f5b1
A few non-data commands that should be allowed while loading or stale
...
SELECT, and HELLO are commands that may be executed by the client
as soon as it connects, there's no reason to block them, preventing the
client from doing the rest of his sequence (which might just be INFO or
CONFIG, etc).
MONITOR, DEBUG, SLOWLOG, TIME, LASTSAVE are all non-data accessing
commands, which there's no reason to block.
2020-02-06 08:53:23 +02:00
fe7e8dc955
Add handling of short read of module id in rdb
2020-02-05 19:47:09 +02:00
3795aaf42a
update RM_SignalModifiedKey doc comment
2020-02-05 18:15:38 +02:00
44ac202fbf
Merge pull request #6831 from oranagra/config_c_refactor_3
...
config.c verbose error replies for CONFIG SET, like config file parsing
2020-02-05 13:41:15 +01:00
ffdd0620d0
config.c verbose error replies for CONFIG SET, like config file parsing
...
We noticed that the error replies for the generic mechanism for enums
are very verbose for config file parsing, but not for config set
command.
instead of replicating this code, i did a small refactoring to share
code between CONFIG SET and config file parsing.
and also renamed the enum group functions to be consistent with the
naming of other types.
2020-02-05 11:41:24 +02:00
9ac6cb9ce4
memoryGetKeys helper function so that ACL can limit access to keys for MEMORY command
2020-02-05 09:42:49 +02:00
90fae58b49
ACL LOG: make max log entries configurable.
2020-02-04 13:19:40 +01:00
0c1a4b5576
ACL LOG: log failed auth attempts.
2020-02-04 12:55:26 +01:00
540b917a26
fix ssl flag check for redis-cli
...
Signed-off-by: lifubang <lifubang@acmcoder.com >
2020-02-04 17:32:30 +08:00
cfe39b7859
Merge pull request #6818 from leomurillo/zskiplistLevels
...
Set ZSKIPLIST_MAXLEVEL to 32
2020-02-04 10:20:56 +01:00
eb2196f5ce
Fix lua related memory leak.
2020-02-04 16:38:46 +08:00
2400f5782e
Merge pull request #6808 from yossigo/fix/redis-cli-openssl-1.0.x
...
TLS: Fix missing initialization in redis-cli.
2020-02-03 16:43:56 +01:00
138ed120dd
fix uninitialized info_cb var in module.c
2020-02-03 16:35:39 +02:00
2fda5f5c98
Exclude "keymiss" notification from NOTIFY_ALL
...
Because "keymiss" is "special" compared to the rest of
the notifications (Trying not to break existing apps
using the 'A' format for notifications)
Also updated redis.conf and module.c docs
2020-02-03 15:43:44 +05:30
560e1e6c4b
Set ZSKIPLIST_MAXLEVEL to optimal value given 2^64 elements and p=0.25
2020-02-02 02:48:00 -06:00
53ac8c7df2
Merge pull request #6812 from guybe7/str_convert_fix
...
ld2string should fail if string contains \0 in the middle
2020-01-30 17:51:04 +01:00
2deb55512f
ld2string should fail if string contains \0 in the middle
...
This bug affected RM_StringToLongDouble and HINCRBYFLOAT.
I added tests for both cases.
Main changes:
1. Fixed string2ld to fail if string contains \0 in the middle
2. Use string2ld in getLongDoubleFromObject - No point of
having duplicated code here
The two changes above broke RM_SaveLongDouble/RM_LoadLongDouble
because the long double string was saved with length+1 (An innocent
mistake, but it's actually a bug - The length passed to
RM_SaveLongDouble should not include the last \0).
2020-01-30 18:15:17 +05:30
396161765b
ACL LOG: also log ACL errors in the scripting/MULTI ctx.
2020-01-30 10:50:32 +01:00
93edb3ff3a
TLS: Fix missing initialization in redis-cli.
2020-01-29 21:40:02 +02:00
30a466ba38
ACL LOG: implement LOG RESET.
2020-01-29 18:51:04 +01:00
6671032faf
ACL LOG: group similar entries in a given time delta.
2020-01-29 18:40:32 +01:00
17ff3173d6
Add more info in the unblockClientFromModule() function.
2020-01-29 12:47:50 +01:00
bf53f9280a
Merge pull request #6699 from guybe7/module_blocked_on_key_timeout_memleak
...
Modules: Fix blocked-client-related memory leak
2020-01-29 12:06:14 +01:00
61dffd8669
ACL LOG: actually emit entries.
2020-01-28 18:04:20 +01:00
e8d0057710
ACL LOG: implement ACL LOG subcommadn skeleton.
2020-01-28 17:30:50 +01:00
3e9e27e98f
ACL LOG: data structures and initial functions.
2020-01-27 18:37:52 +01:00
7ef2270ee7
Change error message for #6775 .
2020-01-15 17:55:24 +01:00
456bbc02c8
Merge pull request #6775 from SqREL/make-error-of-invalid-command-withing-context-explicit
...
Make error when submitting command in incorrect context more explicit
2020-01-15 17:53:51 +01:00
7d5fb5df3f
Setting N I/O threads should mean N-1 additional + 1 main thread.
2020-01-13 18:53:36 +01:00
28d146bed6
Simplify #6379 changes.
2020-01-13 13:25:37 +01:00
9506c860f6
Merge pull request #6739 from trevor211/fixMemoryLeak
...
Fix potential memory leak of rioWriteBulkStreamID().
2020-01-13 13:23:49 +01:00
baa88a1c14
Jump to right label on AOF parsing error.
...
Related to #6054 .
2020-01-13 13:16:15 +01:00
d28948b143
Port PR #6110 to new connection object code.
2020-01-13 12:54:39 +01:00
a8c912ead6
A few comments about main thread serving I/O as well.
...
Related to #6110 .
2020-01-13 12:50:26 +01:00
24896427fc
Merge pull request #6110 from soloestoy/enhance-io-threaded
...
Enhance IO Threaded: use main thread to handle read/write work
2020-01-13 12:46:40 +01:00
b5f52bf01c
Make error when submitting command in incorrect context more explicit
...
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become
`ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
2020-01-10 23:34:15 +02:00
8105f91a02
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2020-01-10 13:15:36 +01:00
b8b8dd5c15
Merge pull request #6114 from ShooterIT/async-rename-rdb
...
Rename rdb when replica finish receiving rdb asynchronously
2020-01-10 13:06:39 +01:00
9466dae4e5
Free fakeclient argv on AOF error.
...
We exit later, so no bug fixed, but it is more correct.
See #6054 , thanks to @ShooterIT for finding the issue.
2020-01-10 13:02:45 +01:00
51a01ca8a6
Merge pull request #6746 from leomurillo/unstable
...
Fix bug on KEYS command where pattern starts with * followed by \x00
2020-01-10 12:18:19 +01:00
bb93686754
Merge pull request #6703 from guybe7/blocking_xread_empty_reply
...
Blocking XREAD[GROUP] should always reply with valid data (or timeout)
2020-01-09 17:32:14 +01:00
64ef0ad71a
Merge pull request #6724 from JohnSully/incremental
...
Add support for incremental build with header files
2020-01-09 17:10:02 +01:00
0f3c353dd3
Merge pull request #6715 from trevor211/fixPotentialClusterLinkError
...
Fix petential cluster link error.
2020-01-09 17:05:54 +01:00
f616ecf361
Merge pull request #6698 from yossigo/ctx-flags-multi-dirty
...
Add REDISMODULE_CTX_FLAGS_MULTI_DIRTY.
2020-01-08 13:09:48 +01:00
2ee4f9f34e
Merge pull request #6748 from hwware/typofix
...
typo fix in acl.c
2020-01-08 13:06:06 +01:00
c89ec5af1e
Merge pull request #6735 from itamarhaber/io-threads
...
Adjusts 'io_threads_num' max in config.c
2020-01-08 12:50:13 +01:00
0e38c5f39c
Merge pull request #6743 from yz1509/unstable
...
Sentinel: avoid sentinel changes promoted_slave to be its own replica.
2020-01-08 12:30:49 +01:00
7080a28efc
XCLAIM: Create the consumer only on successful claims.
...
Fixes #6744 .
2020-01-08 10:10:11 +01:00
