dejun.xdj
c0c06b8456
Streams: add mmid_supp argument in streamParseIDOrReply().
...
If 'mmid_supp' is set to 0, "-" and "+" will be
treated as an invalid ID.
2018-08-02 18:34:34 +02:00
Oran Agra
3662289995
add DEBUG LOG, to to assist test suite debugging
2018-08-02 18:34:34 +02:00
antirez
83d4311acd
Cluster cron announce IP minor refactoring.
2018-08-02 18:34:04 +02:00
shenlongxing
a633f8e130
Fix cluster-announce-ip memory leak
2018-08-02 18:34:04 +02:00
antirez
24c455381a
Tranfer -> transfer typo fixed.
2018-08-02 18:34:04 +02:00
zhaozhao.zz
c609f240a5
refactor dbOverwrite to make lazyfree work
2018-08-02 18:34:04 +02:00
antirez
9e97173988
Refactoring: replace low-level checks with writeCommandsDeniedByDiskError().
2018-08-02 18:34:04 +02:00
antirez
0e77cef096
Fix writeCommandsDeniedByDiskError() inverted return value.
2018-08-02 18:34:04 +02:00
antirez
acfe9d138a
Better top comment for writeCommandsDeniedByDiskError().
2018-08-02 18:34:04 +02:00
antirez
4e933e0059
Introduce writeCommandsDeniedByDiskError().
2018-08-02 18:34:04 +02:00
WuYunlong
41607dfd25
Consider aof write error as well as rdb in lua script.
2018-08-02 18:34:04 +02:00
Salvatore Sanfilippo
1d073a64f7
Merge pull request #5168 from rpv-tomsk/issue-5033
...
INFO CPU: higher precision of reported values
2018-07-30 18:03:15 +02:00
Guy Korland
2db31fd4bb
Few typo fixes
2018-07-30 18:00:32 +02:00
antirez
64242757d7
Add year in log.
...
User: "is there a reason why redis server logs are missing the year in
the "date time"?"
Me: "I guess I did not imagine it would be stable enough to run for
several years".
2018-07-30 18:00:30 +02:00
antirez
9a76472d71
Make dynamic hz actually configurable.
2018-07-30 18:00:24 +02:00
antirez
a330d06c82
Control dynamic HZ via server configuration.
2018-07-30 18:00:21 +02:00
antirez
d42602ffc8
Dynamic HZ: adapt cron frequency to number of clients.
2018-07-30 18:00:19 +02:00
antirez
7b5f0223f8
Dynamic HZ: separate hz from the configured hz.
...
This way we can remember what the user configured HZ is, but change the
actual HZ dynamically if needed in the dynamic HZ feature
implementation.
2018-07-30 18:00:16 +02:00
antirez
037b00dece
Remove useless conditional from emptyDb().
...
Related to #4852 .
2018-07-30 17:59:52 +02:00
antirez
0e97ae79b0
Make emptyDb() change introduced in #4852 simpler to read.
2018-07-30 17:59:49 +02:00
zhaozhao.zz
f7740fafbd
optimize flushdb, avoid useless loops
2018-07-30 17:59:46 +02:00
zhaozhao.zz
0c00837669
Streams: fix xdel memory leak
2018-07-30 17:59:43 +02:00
antirez
dc600a25cd
Example the magic +1 in migrateCommand().
...
Related to #5154 .
2018-07-30 17:59:40 +02:00
antirez
d6827ab638
Make changes of PR #5154 hopefully simpler.
2018-07-30 17:59:37 +02:00
WuYunlong
89ec14531b
Do not migrate already expired keys.
2018-07-30 17:59:35 +02:00
Pavel Rochnyack
cd25ed17b9
INFO CPU: higher precision of reported values
...
Closes : #5033
2018-07-25 21:50:24 +07:00
antirez
6bfb4745fa
Streams: refactoring of next entry seek in the iterator.
...
After #5161 the code could be made a bit more obvious for newcomers.
2018-07-24 11:16:25 +02:00
zhaozhao.zz
4724548e07
Streams: skip master fileds only when we are going forward in streamIteratorGetID
2018-07-24 11:16:21 +02:00
antirez
a1e081f719
string2ll(): better commenting.
2018-07-24 11:16:11 +02:00
dsomeshwar
8b4fe752ec
removing redundant check
2018-07-24 11:16:07 +02:00
antirez
9e5bf0471a
Restore string2ll() to original version.
...
See PR #5157 .
2018-07-24 11:16:05 +02:00
Oran Agra
c2ecdcde98
fix recursion typo in zmalloc_usable
2018-07-24 11:16:00 +02:00
antirez
4f742bd6bf
string2ll(): remove duplicated check for special case.
...
Related to #5157 . The PR author correctly indentified that the check was
duplicated, but removing the second one introduces a bug that was fixed
in the past (hence the duplication). Instead we can remove the first
instance of the check without issues.
2018-07-24 11:15:57 +02:00
antirez
a4efac0067
string2ll(): test for NULL pointer in all the cases.
2018-07-24 11:15:54 +02:00
antirez
2c07c107cb
Change 42 to 1000 as warning level for cached scripts.
...
Related to #4883 .
2018-07-23 18:46:12 +02:00
Itamar Haber
270903d6b2
Adds Lua overheads to MEMORY STATS, smartens the MEMORY DOCTOR
2018-07-23 18:46:12 +02:00
Itamar Haber
faf3dbfcf9
Adds memory information about the script's cache to INFO
...
Implementation notes: as INFO is "already broken", I didn't want to break it further. Instead of computing the server.lua_script dict size on every call, I'm keeping a running sum of the body's length and dict overheads.
This implementation is naive as it **does not** take into consideration dict rehashing, but that inaccuracy pays off in speed ;)
Demo time:
```bash
$ redis-cli info memory | grep "script"
used_memory_scripts:96
used_memory_scripts_human:96B
number_of_cached_scripts:0
$ redis-cli eval "" 0 ; redis-cli info memory | grep "script"
(nil)
used_memory_scripts:120
used_memory_scripts_human:120B
number_of_cached_scripts:1
$ redis-cli script flush ; redis-cli info memory | grep "script"
OK
used_memory_scripts:96
used_memory_scripts_human:96B
number_of_cached_scripts:0
$ redis-cli eval "return('Hello, Script Cache :)')" 0 ; redis-cli info memory | grep "script"
"Hello, Script Cache :)"
used_memory_scripts:152
used_memory_scripts_human:152B
number_of_cached_scripts:1
$ redis-cli eval "return redis.sha1hex(\"return('Hello, Script Cache :)')\")" 0 ; redis-cli info memory | grep "script"
"1be72729d43da5114929c1260a749073732dc822"
used_memory_scripts:232
used_memory_scripts_human:232B
number_of_cached_scripts:2
✔ 19:03:54 redis [lua_scripts-in-info-memory L ✚…⚑] $ redis-cli evalsha 1be72729d43da5114929c1260a749073732dc822 0
"Hello, Script Cache :)"
```
2018-07-23 18:46:12 +02:00
antirez
49841a54db
Fix merge errors.
...
For some reason I made a merge fiasco between 5.0 and unstable.
This fixes the error introduced by merging unstable.
2018-07-23 18:36:54 +02:00
antirez
77a7ec7200
Merge branch 'unstable' into 5.0 branch
2018-07-23 18:29:33 +02:00
antirez
4ff47a0b9b
Top comment clientsCron().
2018-07-20 09:46:18 +02:00
antirez
aba6855282
Clarify that clientsCronTrackExpansiveClients() indexes may jump ahead.
2018-07-20 09:36:48 +02:00
antirez
be88c0b16a
Rename INFO CLIENT max buffers field names for correctness.
...
They are actually delayed a few seconds, so let's call them "recent".
2018-07-19 17:38:20 +02:00
antirez
0cf3794e6e
Fix wrong array index variable in getExpansiveClientsInfo().
2018-07-19 17:34:15 +02:00
antirez
ea3a20c5d0
Change INFO CLIENTS sections to report pre-computed max/min client buffers.
2018-07-19 17:16:19 +02:00
antirez
8f7e496ba5
Rename var in clientsCronTrackExpansiveClients() for clarity.
2018-07-19 13:59:13 +02:00
antirez
8d617596f1
Implement a function to retrieve the expansive clients mem usage.
2018-07-19 13:58:04 +02:00
antirez
85a1b4f807
clientsCronTrackExpansiveClients() actual implementation.
2018-07-19 13:54:20 +02:00
antirez
d4c5fc57db
clientsCronTrackExpansiveClients() skeleton and ideas.
2018-07-19 13:49:00 +02:00
antirez
1c95c07596
Make vars used only by INFO CLIENTS local to the block.
...
Related to #4727 .
2018-07-19 12:23:05 +02:00
Salvatore Sanfilippo
16b8d364cc
Merge pull request #4727 from kingpeterpaule/redis-fix-info-cli
...
move getClientsMaxBuffers func into info clients command
2018-07-19 12:21:35 +02:00