93238575f7
Fix typo
2018-07-03 18:19:46 +02:00
2edcafb35d
addReplySubSyntaxError() renamed to addReplySubcommandSyntaxError().
2018-07-02 18:49:34 +02:00
bc6a004588
Merge pull request #4998 from itamarhaber/module_command_help
...
Module command help
2018-07-02 18:46:56 +02:00
010dc172d4
Update t_stream.c
2018-06-27 16:35:30 +03:00
62f9ac6f43
Streams: Change XADD MAXLEN handling of values <= 0.
...
Now a MAXLEN of 0 really does what it means: it will create a zero
entries stream. This is useful in order to make sure that the behavior
is identical to XTRIM, that must be able to reduce the stream to zero
elements when MAXLEN is given.
Also now MAXLEN with a count < 0 will return an error.
2018-06-18 10:05:21 +02:00
79a1c19ac2
XADD MAXLEN should return an error for values < 0.
2018-06-17 10:44:01 +02:00
6b8a24a665
Streams: generate a few additional events.
...
Currently it does not look it's sensible to generate events for streams
consumer groups modification, being them metadata, however at least for
key-level events, like the creation or removal of a consumer group, I
added a few events here and there. Later we can evaluate if it makes
sense to add more. From the POV instead of WAIT (in Redis transaciton)
and signaling the key as modified, it looks like that the transaction
should not fail when a stream is modified, so no calls are made in
consumer groups related functions to signalModifiedKey().
2018-06-12 18:11:15 +02:00
4774d61691
Streams: improve type correctness in t_stream.c.
2018-06-12 14:12:53 +02:00
6b675b9525
Applies addReplySubSyntaxError to stream commands
2018-06-12 14:52:50 +03:00
bcc42028c1
Fix XGROUP help missing space.
2018-06-12 13:20:46 +02:00
7cc1312789
Streams: fix backward iteration when entry is not flagged SAMEFIELD.
...
See issue #5006 . The comment in the code was also wrong and
was rectified as well.
2018-06-12 10:22:49 +02:00
82661ba329
Merge pull request #5007 from leonchen83/patch-2
...
fix typo issue #5005
2018-06-12 09:28:26 +02:00
923e63e5ec
Streams: increment dirty counter for XGROUP SETID/DESTROY.
...
See issue #5005 comments.
2018-06-12 09:27:40 +02:00
fac3e8aab5
fix typo
...
fix [#5005 ](https://github.com/antirez/redis/issues/5005 )
2018-06-12 08:52:18 +08:00
5db262b623
Merge pull request #5002 from soloestoy/streams-read-or-write
...
Streams: lookupKey[Read->Write]OrReply in xdel and xtrim
2018-06-11 16:33:10 +02:00
295db9ee0a
Merge pull request #5003 from soloestoy/streams-checkType
...
Streams: checkType for xread & xinfo
2018-06-11 16:32:00 +02:00
b8913ce721
Streams: checkType for xread & xinfo
2018-06-11 01:17:52 +08:00
cc81c6f1d3
Streams: lookupKey[Read->Write]OrReply in xdel and xtrim
2018-06-11 00:14:17 +08:00
c04082cf13
Abort in XGROUP if the key is not a stream
2018-06-10 08:55:58 -07:00
66c6218a3c
Merge pull request #4977 from michael-grunder/xpending-early-return
...
Return early in XPENDING if sent a nonexistent consumer group.
2018-06-07 18:49:09 +02:00
a7dbe37d53
Typo: entires -> entries in several places.
2018-06-07 14:36:56 +02:00
6d34ff3645
Streams: max node limits only checked if non zero.
2018-06-07 14:30:25 +02:00
19a438e2c0
Streams: use non static macro node limits.
...
Also add the concept of size/items limit, instead of just having as
limit the number of bytes.
2018-06-07 14:24:49 +02:00
b61416bdf4
Fix streamIteratorRemoveEntry() to update elements count.
...
Close #4989 .
2018-06-06 11:40:22 +02:00
9e25f3e1de
Remove XINFO <key> special form.
...
As observed by Michael Grunder this usage while practical is
inconsistent because for instance it does not work against a key called
HELP. Removed.
2018-06-05 16:34:34 +02:00
36b392a0b2
XGROUP SETID implemented + consumer groups core fixes.
...
Now that we have SETID, the inetrnals of consumer groups should be able
to handle the case of the same message delivered multiple times just
as a side effect of calling XREADGROUP. Normally this should never
happen but if the admin manually "XGROUP SETID mykey mygroup 0",
messages will get re-delivered to clients waiting for the ">" special
ID. The consumer groups internals were not able to handle the case of a
message re-delivered in this circumstances that was already assigned to
another owner.
2018-06-04 17:28:03 +02:00
7c6f1be5df
XGROUP DESTROY implemented.
2018-06-04 12:58:26 +02:00
1749fe7a26
Return early in XPENDING if sent a nonexistent consumer group.
2018-06-02 18:22:20 -07:00
3d5e2c62e2
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-05-29 12:41:07 +02:00
6536ce27a4
Streams: fix comments referring to old ID format.
2018-05-25 17:25:19 +02:00
c2d7e6cea7
avoid warning in t_stream.c
2018-05-25 22:49:49 +08:00
fb9c1c3dbd
Simplify XADD ID syntax error code path,.
2018-05-25 16:29:37 +02:00
a60f553b68
Merge pull request #4832 from 0xtonyxia/fix-xadd-ID-parse
...
Bugfix: xadd command ID parse
2018-05-25 16:27:21 +02:00
95fa564add
Avoid warning by explicitly initializing var to NULL.
2018-05-25 16:19:14 +02:00
b2b4e186a2
Explicitly cast void pointers to char pointers for printf style logging.
2018-05-25 16:15:59 +02:00
8a200b04c3
Merge pull request #4831 from 0xtonyxia/fix-xadd-arity-check
...
Bugfix: xadd comand <field,value> arity check
2018-05-24 16:07:19 +02:00
e6b0e8d9ec
Streams: XTRIM command added.
2018-04-19 16:25:29 +02:00
19ae809458
Streams: XADD, handle signaling of write in different ways.
2018-04-19 16:11:43 +02:00
aba76320d5
Streams: XDEL command.
2018-04-18 13:12:09 +02:00
9c149bf1f1
Streams: higher level "delete by ID" API for streams.
2018-04-17 17:55:56 +02:00
24ac2b4c74
Streams: iterator entry deletion abilities.
2018-04-17 17:18:00 +02:00
b6b00f35ca
Return more accurate message when specified ID is invalid
2018-04-10 17:11:10 +08:00
3c20b3fc24
Bugfix: xadd command ID parse
...
strictly check the string to be converted,
strtoull() in libc may not set errno to EINVAL when the string contains
invalid digits.
2018-04-10 17:05:48 +08:00
07125b8d22
Bugfix: xadd comand <field,value> arity check
...
missing parenthesis causes wrong arithmetic priority.
2018-04-10 16:36:05 +08:00
71c7477fd4
fix memory leak for streamPropagateXCLAIM
2018-03-21 17:41:59 +09:00
233da29f4d
CG: propagate XACK by incrementing server.dirty.
...
This should be more than enough, even if in case of partial IDs that are
not found, we send all the IDs to the slave/AOF, but this is definitely
a corner case without bad effects if not some wasted space.
2018-03-20 17:53:45 +01:00
5577130451
CG: Make XINFO Great Again (and more Redis-ish).
...
With XINFO out of the blue I invented a new syntax for commands never
used in Redis in the past... Let's fix it and make it
Great Again!!11one (TM)
2018-03-20 11:52:42 +01:00
2ba9a57c9a
CG: Add JUSTID to XCLAIM propagation to reduce CPU usage.
2018-03-20 11:25:49 +01:00
ad716e29c0
CG: Fix propagate() arg count in streamPropagateXCLAIM().
2018-03-20 11:13:41 +01:00
3cae5f0321
CG: XGROUP CREATE/DELCONUSMER replication.
2018-03-20 11:07:01 +01:00
