68b911478f
Fixed typo in release candidate notes.
2013-11-10 10:25:09 +01:00
7d30b3121d
Deprecate utils/redis-copy.rb in favor of redis-copy gem
2013-11-08 06:33:04 +00:00
875bc51909
Fix broken rdbWriteRaw() return value check in rdb.c.
...
Thanks to @PhoneLi for reporting.
2013-11-07 23:54:46 +01:00
c874e39c45
Sentinel: sentinelSendSlaveOf() was missing a var and the prototype.
2013-11-06 11:29:57 +01:00
1767998751
Sentinel: increment pending_commands counter in two more places.
...
AUTH and SCRIPT KILL were sent without incrementing the pending commands
counter. Clearly this needs some kind of wrapper doing it for the caller
in order to be less bug prone.
2013-11-06 11:29:53 +01:00
97810c45e8
Sentinel: always send CONFIG REWRITE when changing instance role.
...
This change makes Sentinel less fragile about a number of failure modes.
This commit also fixes a different bug as a side effect, SLAVEOF command
was sent multiple times without incrementing the pending commands count.
2013-11-06 11:29:49 +01:00
f7f97bf730
Redis 2.7.106 (2.8 Release Candidate 6).
2013-11-06 09:24:26 +01:00
3a66e0c157
Fixed typo in parseScanCursorOrReply(): ad -> at.
...
Thanks to @badboy for reporting it.
2013-11-05 17:25:34 +01:00
060d56e7eb
SCAN code refactored to parse cursor first.
...
The previous implementation of SCAN parsed the cursor in the generic
function implementing SCAN, SSCAN, HSCAN and ZSCAN.
The actual higher-level command implementation only checked for empty
keys and return ASAP in that case. The result was that inverting the
arguments of, for instance, SSCAN for example and write:
SSCAN 0 key
Instead of
SSCAN key 0
Resulted into no error, since 0 is a non-existing key name very likely.
Just the iterator returned no elements at all.
In order to fix this issue the code was refactored to extract the
function to parse the cursor and return the error. Every higher level
command implementation now parses the cursor and later checks if the key
exist or not.
2013-11-05 17:25:29 +01:00
162acd8ac2
SCAN: when iterating ziplists or intsets always return cursor of 0.
...
The previous implementation assumed that the first call always happens
with cursor set to 0, this may not be the case, and we want to return 0
anyway otherwise the (broken) client code will loop forever.
2013-11-05 17:24:33 +01:00
406be0ea28
Use strtoul() instead of sscanf() in SCAN implementation.
2013-11-05 17:24:30 +01:00
4b615eea8f
Added tests for [SHZ]SCAN with MATCH.
2013-11-05 17:24:26 +01:00
54a5a7dff8
HSCAN/ZSCAN: skip value when matching.
...
This fixes issue #1360 and #1362 .
2013-11-05 17:24:22 +01:00
bebbc7f9f7
Pass int64_t to intsetGet() instead of long long.
2013-11-05 17:24:17 +01:00
736e343509
removed not used vars in dictScan().
2013-11-05 17:24:12 +01:00
59b30b327d
SCAN: no sdsEncodedObject() API in Redis 2.8.
2013-10-31 18:22:29 +01:00
3d3e350b12
SSCAN with integer encoded object test improved.
2013-10-31 10:38:56 +01:00
3cc7d486bc
Inverted variable boolean value and name after scanGenericCommand() refactoring.
2013-10-31 10:38:52 +01:00
06455014aa
scanGenericCommand() refactoring and handling of integer encoded elements.
...
This commit fixes issue #1354 .
2013-10-31 10:38:48 +01:00
141f30f421
Regression test added for [SHZ]SCAN issue #1354 .
2013-10-31 10:38:45 +01:00
c53cab5dde
Test: added a SCAN test trying to trigger HT resize.
2013-10-30 16:51:48 +01:00
ab6f4195dd
Test: added ZSCAN test.
2013-10-30 16:27:43 +01:00
13e879c9cf
Test: added HSCAN test.
2013-10-30 16:27:39 +01:00
9ea69a58ac
Test: added SSCAN test.
2013-10-30 16:27:36 +01:00
bd1962acc4
SCAN test keys sorting turned into more idiomatic Tcl.
2013-10-30 16:27:31 +01:00
02617b6e92
SCAN: tests moved to unit/scan.tcl.
2013-10-30 16:27:28 +01:00
bb2df795e0
Aesthetic fix (missing space) into HSCAN and ZSCAN implementations.
...
Thanks to @badboy for reporting.
2013-10-29 16:21:21 +01:00
35816a2e4d
ZSCAN implemented.
2013-10-29 16:21:18 +01:00
1cc7e646af
HSCAN implemented.
2013-10-29 16:21:13 +01:00
24ecabc995
SSCAN implemented.
2013-10-29 16:21:01 +01:00
17785f40b5
dictScan(): empty hash table requires special handling.
2013-10-29 16:20:13 +01:00
7f063b1c8c
SCAN is a random command and does not require output sorting.
...
Sorting the output helps when we want to turn a non-deterministic into a
deterministic command, in that case this is not possible.
2013-10-29 16:20:10 +01:00
9e62d9e79c
SCAN: refactored into scanGenericCommand.
...
The new implementation is capable of iterating the keyspace but also
sets, hashes, and sorted sets, and can be used to implement SSCAN, ZSCAN
and HSCAN.
2013-10-29 16:20:06 +01:00
1a06bbe430
Fixed typos in dictScan() comment.
2013-10-29 16:20:02 +01:00
0880bec4e2
dictScan() algorithm documented.
2013-10-29 16:19:57 +01:00
1d659784f4
SCAN: stay inside 80 cols.
2013-10-29 16:19:54 +01:00
854b8be616
Revert "Fixed typo in SCAN comment. iff -> if."
...
Probably here Pieter means "if and only if".
This reverts commit 43fdf3b404
2013-10-29 16:19:49 +01:00
5fa5153bf5
SCAN: simplify keys list cleanup using listSetFreeMethod().
2013-10-29 16:19:45 +01:00
108c6e6734
SCAN: Fix test after option renamed from PATTERN to MATCH.
2013-10-29 16:19:41 +01:00
21da9b06a4
SCAN: improve variable names for readability.
2013-10-29 16:19:37 +01:00
907e06cd61
SCAN: remove additional newlines to conform to Redis code base.
2013-10-29 16:19:33 +01:00
b44f1589a4
SCAN: remove useless assertion, already enforced by command table.
2013-10-29 16:19:28 +01:00
d1c1f62ed5
SCAN: use define REDIS_LONGSTR_SIZE instead of fixed len.
2013-10-29 16:19:25 +01:00
8cdaf604ce
Fixed typo in SCAN comment. iff -> if.
2013-10-29 16:19:21 +01:00
33409b4c6c
SCAN option name changed: pattern -> match.
2013-10-29 16:19:17 +01:00
fd22106a98
Fix error in scan algorithm
...
The irrelevant bits shouldn't be masked to 1. This can result in slots being
skipped when the hash table is resized between calls to the iterator.
2013-10-29 16:19:12 +01:00
8c4ff679fe
SCAN requires at least 1 argument
2013-10-29 16:19:08 +01:00
0dd95e23ab
Add SCAN command
2013-10-29 16:18:24 +01:00
9546f7846b
redis-benchmark: update help for new __rand_int__ form.
2013-10-28 18:14:11 +01:00
508d3c1bb7
Redis 2.7.105 (2.8 Release Candidate 5).
2013-10-09 13:08:42 +02:00
