5fd6dee0e6
Fixed typo in parseScanCursorOrReply(): ad -> at.
...
Thanks to @badboy for reporting it.
2013-11-05 17:23:11 +01:00
ebcb6251e6
SCAN code refactored to parse cursor first.
...
The previous implementation of SCAN parsed the cursor in the generic
function implementing SCAN, SSCAN, HSCAN and ZSCAN.
The actual higher-level command implementation only checked for empty
keys and return ASAP in that case. The result was that inverting the
arguments of, for instance, SSCAN for example and write:
SSCAN 0 key
Instead of
SSCAN key 0
Resulted into no error, since 0 is a non-existing key name very likely.
Just the iterator returned no elements at all.
In order to fix this issue the code was refactored to extract the
function to parse the cursor and return the error. Every higher level
command implementation now parses the cursor and later checks if the key
exist or not.
2013-11-05 15:47:50 +01:00
b4048dfec0
SCAN: when iterating ziplists or intsets always return cursor of 0.
...
The previous implementation assumed that the first call always happens
with cursor set to 0, this may not be the case, and we want to return 0
anyway otherwise the (broken) client code will loop forever.
2013-11-05 15:32:25 +01:00
101d4bf867
Use strtoul() instead of sscanf() in SCAN implementation.
2013-11-05 15:30:21 +01:00
bf79c0cda2
Added tests for [SHZ]SCAN with MATCH.
2013-11-05 15:19:44 +01:00
f56f78d159
HSCAN/ZSCAN: skip value when matching.
...
This fixes issue #1360 and #1362 .
2013-11-05 12:16:29 +01:00
1a0cea33a0
Cluster: initialize senderConfigEpoch and senderCurrentEpoch for warnings suppression.
2013-11-05 12:01:07 +01:00
eb95d28898
Pass int64_t to intsetGet() instead of long long.
2013-11-05 11:57:30 +01:00
20fb91fd31
removed not used vars in dictScan().
2013-11-05 11:56:11 +01:00
6cf230ea91
Initial support for --replicas in redis-trib.
2013-11-05 11:24:24 +01:00
9fba193a59
SSCAN with integer encoded object test improved.
2013-10-31 10:37:27 +01:00
c4ca5f99bf
Inverted variable boolean value and name after scanGenericCommand() refactoring.
2013-10-31 10:35:56 +01:00
8fc85a1218
scanGenericCommand() refactoring and handling of integer encoded elements.
...
This commit fixes issue #1354 .
2013-10-31 10:32:39 +01:00
e6bb738b87
Regression test added for [SHZ]SCAN issue #1354 .
2013-10-31 09:43:21 +01:00
0b8a0ca4bc
Test: added a SCAN test trying to trigger HT resize.
2013-10-30 16:50:25 +01:00
6cb52256c9
Test: added ZSCAN test.
2013-10-30 16:25:53 +01:00
1b960378e8
Test: added HSCAN test.
2013-10-30 16:24:39 +01:00
ddc80e026f
Test: added SSCAN test.
2013-10-30 11:58:04 +01:00
5fdb94fd98
SCAN test keys sorting turned into more idiomatic Tcl.
2013-10-30 11:36:12 +01:00
a881827b6e
SCAN: tests moved to unit/scan.tcl.
2013-10-30 11:34:01 +01:00
3c7a0677b0
redis-benchmark: update help for new __rand_int__ form.
2013-10-28 18:13:42 +01:00
9b2d44e63f
Aesthetic fix (missing space) into HSCAN and ZSCAN implementations.
...
Thanks to @badboy for reporting.
2013-10-28 13:20:11 +01:00
2c643ffa8d
ZSCAN implemented.
2013-10-28 11:36:42 +01:00
e50090aa06
HSCAN implemented.
2013-10-28 11:35:26 +01:00
4a1f1cc0d7
SSCAN implemented.
2013-10-28 11:17:32 +01:00
dfeaa84d46
dictScan(): empty hash table requires special handling.
2013-10-28 11:17:18 +01:00
cd8cb49dc4
SCAN is a random command and does not require output sorting.
...
Sorting the output helps when we want to turn a non-deterministic into a
deterministic command, in that case this is not possible.
2013-10-28 11:13:43 +01:00
442ae833b2
SCAN: refactored into scanGenericCommand.
...
The new implementation is capable of iterating the keyspace but also
sets, hashes, and sorted sets, and can be used to implement SSCAN, ZSCAN
and HSCAN.
2013-10-28 11:11:34 +01:00
7bd45659b9
Fixed typos in dictScan() comment.
2013-10-25 17:05:55 +02:00
34c207227c
dictScan() algorithm documented.
2013-10-25 17:01:30 +02:00
48ea8a0a11
SCAN: stay inside 80 cols.
2013-10-25 12:01:49 +02:00
df13adb037
Revert "Fixed typo in SCAN comment. iff -> if."
...
Probably here Pieter means "if and only if".
This reverts commit 43fdf3b404
2013-10-25 12:00:13 +02:00
a25fe0b28d
SCAN: simplify keys list cleanup using listSetFreeMethod().
2013-10-25 11:58:03 +02:00
0471b90844
SCAN: Fix test after option renamed from PATTERN to MATCH.
2013-10-25 11:55:28 +02:00
fd1b0ad07c
SCAN: improve variable names for readability.
2013-10-25 11:54:45 +02:00
908eba5a8f
SCAN: remove additional newlines to conform to Redis code base.
2013-10-25 11:51:08 +02:00
6e55e543c6
SCAN: remove useless assertion, already enforced by command table.
2013-10-25 11:49:08 +02:00
64722b0946
SCAN: use define REDIS_LONGSTR_SIZE instead of fixed len.
2013-10-25 11:48:18 +02:00
43fdf3b404
Fixed typo in SCAN comment. iff -> if.
2013-10-25 11:46:02 +02:00
9c88ace927
SCAN option name changed: pattern -> match.
2013-10-25 11:45:32 +02:00
b63fbea5e4
Fix error in scan algorithm
...
The irrelevant bits shouldn't be masked to 1. This can result in slots being
skipped when the hash table is resized between calls to the iterator.
2013-10-25 10:50:03 +02:00
7a6cfb18f3
SCAN requires at least 1 argument
2013-10-25 10:49:56 +02:00
7f490b197f
Add SCAN command
2013-10-25 10:49:48 +02:00
85f52ebcd8
Cluster: rough support for sub-command options in redis-trib.
2013-10-11 17:33:19 +02:00
0c9f60a628
Cluster: there is a lower limit for the handshake timeout.
2013-10-11 10:34:32 +02:00
1447d28c0f
Cluster: data_age conversion to milliseconds fixed.
2013-10-09 16:36:06 +02:00
573c2fea91
Cluster: clusterCron() freq is now 10h. Still ping 1 node every sec.
...
After the change in clusterCron() frequency of call, we still want to
ping just one random node every second.
2013-10-09 16:29:17 +02:00
e5864c73b6
Cluster: example redis.conf updated from sec to ms for cluster-node-timeout.
2013-10-09 16:21:27 +02:00
ba42428633
Cluster: time switched from seconds to milliseconds.
...
All the internal state of cluster involving time is now using mstime_t
and mstime() in order to use milliseconds resolution.
Also the clusterCron() function is called with a 10 hz frequency instead
of 1 hz.
The cluster node_timeout must be also configured in milliseconds by the
user in redis.conf.
2013-10-09 16:19:26 +02:00
929b6a4480
Cluster: cluster stuff moved from redis.h to cluster.h.
2013-10-09 15:38:05 +02:00
