Commit Graph

5877 Commits

Author SHA1 Message Date
87672adee2 Lua debugger: better support for synchronous mode. 2015-11-17 15:43:22 +01:00
7be9170585 Lua debugger: handle forked sessions children during shutdown. 2015-11-17 15:43:22 +01:00
3ab0b4d6d0 Lua debugger: inform user changes are rolled back.
When redis-cli will support the synchronous mode, this will not be
printed.
2015-11-17 15:43:22 +01:00
56d9bb8c55 Lua debugger: fix help typo, beark -> break. 2015-11-17 15:43:22 +01:00
e386cd8ccf Lua debugger: clear end of session protocol.
When the debugger exits now it produces an <endsession> tag that informs
redis-cli (or other debugging clients) that the session terminated.
This way the client knows there is yet another reply to read (the one of
the EVAL script itself), and can switch to non-debugging mode ASAP.
2015-11-17 15:43:22 +01:00
7492237c3c Lua debugger: redis.debug() implemented. 2015-11-17 15:43:22 +01:00
23a4d70e56 Lua debugger: redis-cli, mark end of debugging session. 2015-11-17 15:43:22 +01:00
cd112db0ae Lua debugger: removing breakpoints now works. 2015-11-17 15:43:22 +01:00
a076e421e9 Lua debugger: redis command implemented. 2015-11-17 15:43:22 +01:00
e6eb6eadec Lua debugger: try to eval as expression first.
It's handly to just eval "5+5" without the return and see it printed on
the screen as result. However prepending "return" does not always result
into valid Lua code. So what we do is to exploit a common Lua community
trick of trying to compile with return prepended, and if compilation
fails then it's not an expression that can be returned, so we try again
without prepending "return". Works great apparently.
2015-11-17 15:43:21 +01:00
1f8fdafe65 Lua debugger: much better Lua values pretty printer. 2015-11-17 15:43:21 +01:00
f4805800dc Lua debugger: print now handles ARGV and KEYS. 2015-11-17 15:43:21 +01:00
36392dd867 Lua debugger: added comment about helper functions. 2015-11-17 15:43:21 +01:00
3a04cb05ee Lua debugger: redis.breakpoint() implemented. 2015-11-17 15:43:21 +01:00
cf4700bda4 Lua debugger: output improvements, eval command. 2015-11-17 15:43:21 +01:00
1f8d614423 Lua debugger: breakpoints. 2015-11-17 15:43:21 +01:00
5c4f492844 Lua debugger: ability to show local vars content. 2015-11-17 15:43:21 +01:00
5417217c87 Lua debugger: log Redis commands. List command. 2015-11-17 15:43:21 +01:00
d3d1fa9437 Lua debugger: initial REPL. 2015-11-17 15:43:20 +01:00
c494db89b5 Lua debugger: foundations implemented. 2015-11-17 15:43:20 +01:00
7cfdccd94e Remove "s" flag for MIGRATE in command table.
Maybe there are legitimate use cases for MIGRATE inside Lua scripts, at
least for now. When the command will be executed in an asynchronous
fashion (planned) it is possible we'll no longer be able to permit it
from within Lua scripts.
2015-11-17 15:43:13 +01:00
f3dd472e97 Update redis-cli help and the script to generate it. 2015-11-17 15:38:34 +01:00
0cb66fa156 Fix MIGRATE entry in command table.
Thanks to Oran Agra (@oranagra) for reporting. Key extraction would not
work otherwise and it does not make sense to take wrong data in the
command table.
2015-11-17 15:33:09 +01:00
8a0258aa43 AOF: rewriting child killed by SIGUSR1 is not an error. 2015-11-13 09:32:20 +01:00
54f5ecfd49 call() deserves a good top-comment. 2015-11-10 13:31:25 +01:00
c950facf43 Merge pull request #2848 from badboy/removed-printf
Remove printf
2015-11-09 18:06:41 +01:00
87a12a6085 Best effort flush of slave buffers before SHUTDOWN. 2015-11-09 17:26:58 +01:00
b719eedfc6 Use clientHasPendingReplies() in flushSlavesOutputBuffers()
The old version only flushed data to slaves if there were strings
pending in the client->reply list. Now also static buffers are flushed.
Does not help to free memory (which is the only use we have right now in
the fuction), but is more correct conceptually, and may be used in
other contexts.
2015-11-09 17:07:46 +01:00
1b5d24eb2b Scripting: fix redis.call() error reporting.
Arguments arity and arguments type error of redis.call() were not
reported correctly to Lua, so the command acted in this regard like
redis.pcall(), but just for two commands. Redis.call() should always
raise errors instead.
2015-11-09 11:43:51 +01:00
111d24f246 Fix error reply in subscribed Pub/Sub mode.
PING is now a valid command to issue in this context.
2015-11-09 11:10:53 +01:00
cd8f19e9ca Initialize all Lua scripting related things into scripting.c 2015-11-05 11:37:39 +01:00
9aa1f94449 scripting.c source code better organized into sections. 2015-11-05 10:37:10 +01:00
71aa9b75f2 Fix HINCRBYFLOAT to work with long doubles.
During the refactoring needed for lazy free, specifically the conversion
of t_hash from struct robj to plain SDS strings, HINCRBFLOAT was
accidentally moved away from long doubles to doubles for internal
processing of increments and formatting.

The diminished precision created more obvious artifacts in the way small
numbers are formatted once we convert from decimal number in radix 10 to
double and back to its string in radix 10.

By using more precision, we now have less surprising results at least
with small numbers like "1.23", exactly like in the previous versions of
Redis.

See issue #2846.
2015-11-04 17:16:34 +01:00
f6255703b0 Add regression test for HINCRBYFLOAT formatting change.
This test was kindly provided by Jan-Erik Rediger (@badboy here on
Github) that discovered the issue.

See issue #2846.
2015-11-04 17:02:34 +01:00
de776a402f Merge pull request #2850 from Joe8Bit/fix_typo-in-readme
Fix typo in READme sever/server
2015-11-04 12:59:11 +01:00
dfe90acbd5 README new internals section improved a bit more. 2015-11-04 12:58:26 +01:00
8bc8f6f695 Fix typo in READme sever/server 2015-11-04 11:54:50 +00:00
462026ceb7 README: remove garbage at end of line. 2015-11-04 12:52:37 +01:00
73510f4e38 README operations -> commands, is more clear now #2. 2015-11-04 12:51:45 +01:00
b9fb24014a README operations -> commands, is more clear now. 2015-11-04 12:50:32 +01:00
8badf160b6 A few README typos fixed #2. 2015-11-04 12:44:36 +01:00
d80d051792 A few README typos fixed. 2015-11-04 12:41:54 +01:00
15d57c35c3 README now has info about Redis codebase layout. 2015-11-04 12:29:54 +01:00
35afefc7cb Remove printf 2015-11-04 11:48:14 +01:00
30b324698f Test: improve PFCOUNT with multiple keys testing.
An user raised a question about a given behavior of PFCOUNT. Added a
test to show the behavior (union) is correct when most of the items are
in common.
2015-11-03 19:03:17 +01:00
77362b9027 Dependencies updated. 2015-10-30 12:15:07 +01:00
5b63ae37ff Scripting: commands replication tests. 2015-10-30 12:06:09 +01:00
f26072eb66 More reliable DEBUG loadaof.
Make sure to flush the AOF output buffers before reloading.
Result: less false timing related false positives on AOF tests.
2015-10-30 12:06:09 +01:00
073a42b997 Scripting: execute tests with command replication as well. 2015-10-30 12:06:09 +01:00
ff6d296000 Scripting: ability to turn on Lua commands style replication globally.
Currently this feature is only accessible via DEBUG for testing, since
otherwise depending on the instance configuration a given script works
or is broken, which is against the Redis philosophy.
2015-10-30 12:06:09 +01:00