0f0610eb01
Streams: better naming: lastid_updated -> propagate_last_id.
...
See #5437 but also I updated a previous usage of the same var name.
2018-10-15 13:05:35 +02:00
a745e4234d
Streams: panic if streamID invalid after check, should not be possible.
2018-10-15 13:05:35 +02:00
9974be13a4
Streams: propagate lastid in XCLAIM when it has effect
2018-10-15 13:05:35 +02:00
69a628d0f0
Streams: XCLAIM ignore minidle if NACK is created by FORCE
...
Because the NACK->consumer is NULL, if idletime < minidle
the NACK does not belong to any consumer, then redis will crash
in XPENDING.
2018-10-15 13:05:35 +02:00
a04b43c7ea
Streams: bugfix XCLAIM should propagate group name not consumer name
2018-10-15 13:05:35 +02:00
b501fd5d3e
Fix propagation of consumer groups last ID.
...
Issue #5433 .
2018-10-15 13:05:17 +02:00
2007d30c9d
Refactoring of XADD / XTRIM MAXLEN rewriting.
...
See #5141 .
2018-10-09 18:30:49 +02:00
041161b7ce
Streams: propagate specified MAXLEN instead of approximated
...
Slaves and rebooting redis may have different radix tree struct,
by different stream* config options. So propagating approximated
MAXLEN to AOF/slaves may lead to date inconsistency.
2018-10-09 18:30:34 +02:00
f04d799bb9
Streams: reset approx_maxlen in every maxlen loop
2018-10-09 18:30:34 +02:00
affd93654f
Streams: XTRIM will return an error if MAXLEN with a count < 0
2018-10-09 18:30:34 +02:00
4c405ad07f
Streams: propagate original MAXLEN argument in XADD context
...
If we rewrite the MAXLEN argument as zero when no trimming
was performed, date between master and slave and aof will
be inconsistent, because `xtrim maxlen 0` means delete all
entries in stream.
2018-10-09 18:30:34 +02:00
c4ab5a05a7
xclaimCommand(): fix comment typos.
2018-10-09 18:30:13 +02:00
dc0b628a8e
streamAppendItem(): Update the radix tree pointer only if changed.
2018-10-03 11:19:32 +02:00
260b53a284
streamIteratorRemoveEntry(): set back lp only if pointer changed.
...
Most of the times the pointer will remain the same since integers of
similar size don't take more space in listpacks.
Related to #5210 .
2018-10-03 11:19:32 +02:00
5d12f9d98b
Streams: update listpack with new pointer in XDEL
2018-10-03 11:19:32 +02:00
a996b2a285
Fix XINFO comment for consistency.
2018-10-03 11:19:32 +02:00
7ded552d6d
add missing argument to function doc
2018-10-03 11:18:55 +02:00
eea0d3c50a
#5299 Fix blocking XREAD for streams that ran dry
...
The conclusion, that a xread request can be answered syncronously in
case that the stream's last_id is larger than the passed last-received-id
parameter, assumes, that there must be entries present, which could be
returned immediately.
This assumption fails for empty streams that actually contained some
entries which got removed by xdel, ... .
As result, the client is answered synchronously with an empty result,
instead of blocking for new entries to arrive.
An additional check for a non-empty stream is required.
2018-08-29 19:12:29 +02:00
b59f04a099
Streams: ID of xclaim command starts from the sixth argument.
2018-08-29 12:28:09 +02:00
a3f2437bdd
Fix stream command paras
2018-08-29 12:28:06 +02:00
fbbcc6a657
Streams IDs parsing refactoring.
...
Related to #5184 .
2018-08-02 18:34:42 +02:00
bd2f3f6bb1
Streams: rearrange the usage of '-' and '+' IDs in stream commands.
2018-08-02 18:34:34 +02:00
c0c06b8456
Streams: add mmid_supp argument in streamParseIDOrReply().
...
If 'mmid_supp' is set to 0, "-" and "+" will be
treated as an invalid ID.
2018-08-02 18:34:34 +02:00
0c00837669
Streams: fix xdel memory leak
2018-07-30 17:59:43 +02:00
6bfb4745fa
Streams: refactoring of next entry seek in the iterator.
...
After #5161 the code could be made a bit more obvious for newcomers.
2018-07-24 11:16:25 +02:00
4724548e07
Streams: skip master fileds only when we are going forward in streamIteratorGetID
2018-07-24 11:16:21 +02:00
49841a54db
Fix merge errors.
...
For some reason I made a merge fiasco between 5.0 and unstable.
This fixes the error introduced by merging unstable.
2018-07-23 18:36:54 +02:00
77a7ec7200
Merge branch 'unstable' into 5.0 branch
2018-07-23 18:29:33 +02:00
6201f7b4e0
Streams: better error when $ is given with XREADGROUP.
2018-07-17 17:54:10 +02:00
4bff45c7a6
Merge pull request #5136 from 0xtonyxia/fix-xread-id-parse
...
Fix xreadgroup with '$' ID.
2018-07-17 17:50:31 +02:00
846cf12ae5
Streams: remove meaningless if condition.
...
It's already checked if xreadgroup is set and groupname is NULL.
2018-07-17 18:23:47 +08:00
6501b6bb6d
Streams: return an error message if using xreadgroup with '$' ID.
...
Redis will always return an empty result when '$' ID is specified
with xreadgroup command, it's meaningless.
2018-07-17 18:19:10 +08:00
9fbd49bbaf
Merge pull request #5113 from 0xtonyxia/using-compare-func-instead
...
Streams: using streamCompareID() instead of direct compare.
2018-07-16 18:34:35 +02:00
73306c6fed
Streams: correctly propagate xdel if needed
2018-07-16 20:48:07 +08:00
103c5a1a3c
Add a few comments to streamIteratorRemoveEntry().
2018-07-16 12:41:55 +02:00
a317f55d25
Merge pull request #5131 from soloestoy/optimize-xdel
...
Streams: free lp if all elements are deleted
2018-07-16 12:39:38 +02:00
185e0d9cd8
Modify XINFO field from last-id to last-generated-id.
...
Related to #5129 .
2018-07-16 12:25:26 +02:00
c9324f81a2
Streams: free lp if all elements are deleted
2018-07-16 15:57:41 +08:00
b4ba5ac840
Streams: show last id for streams and groups
2018-07-16 13:24:54 +08:00
0484dbcf68
Streams: using streamCompareID() instead of direct compare.
2018-07-14 20:34:06 +08:00
b6260a0270
Streams: when re-delivering because of SETID, reset deliveries counter.
...
We don't want to increment the deliveries here, because the sysadmin
reset the consumer group so the desire is likely to restart processing,
and having the PEL polluted with old information is not useful but
probably confusing.
Related to #5111 .
2018-07-12 13:19:39 +02:00
a7c180e559
Simplify duplicated NACK #5112 fix.
...
We don't really need to distinguish between the case the consumer is the
same or is a different one.
2018-07-12 13:15:54 +02:00
bf4def0fbc
Merge pull request #5112 from 0xtonyxia/fix-xreadgroup-crash-after-setid
...
Streams: fix xreadgroup crash after xgroup SETID is sent.
2018-07-12 13:04:22 +02:00
0420c3276f
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2018-07-10 12:06:44 +02:00
a8c1bb310e
Streams: fix new XREADGROUP sync logic.
2018-07-10 12:02:03 +02:00
1a02b5f6ee
Streams: make blocking for > a truly special case.
...
To simplify the semantics of blocking for a group, this commit changes
the implementation to better match the description we provide of
conusmer groups: blocking for > will make the consumer waiting for new
elements in the group. However blocking for any other ID will always
serve the local history of the consumer.
However it must be noted that the > ID is actually an alias for the
special ID ms/seq of UINT64_MAX,UINT64_MAX.
2018-07-10 11:34:17 +02:00
3f8a3efe5f
Streams: fix xreadgroup crash after xgroup SETID is sent.
...
For issue #5111 .
2018-07-10 16:26:13 +08:00
61f12973f7
Bugfix: PEL is incorrect when consumer is blocked using xreadgroup with NOACK option.
...
Save NOACK option into client.blockingState structure.
2018-07-09 13:40:29 +02:00
93238575f7
Fix typo
2018-07-03 18:19:46 +02:00
2edcafb35d
addReplySubSyntaxError() renamed to addReplySubcommandSyntaxError().
2018-07-02 18:49:34 +02:00
