fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-06-24 22:41:32 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7029 from valentinogeron/fix-xack

Browse Source 
XACK should be executed in a "all or nothing" fashion.
This commit is contained in:
Salvatore Sanfilippo
2020-04-02 11:23:23 +02:00
committed by GitHub
parent 8d6dc136e1 1547d72cf3
commit dfef407499
2 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/t_stream.c
View File

@ -1922,11 +1922,21 @@ void xackCommand(client *c) {
return;
}
/* Start parsing the IDs, so that we abort ASAP if there is a syntax
* error: the return value of this command cannot be an error in case
* the client successfully acknowledged some messages, so it should be
* executed in a "all or nothing" fashion. */
for (int j = 3; j < c->argc; j++) {
streamID id;
if (streamParseStrictIDOrReply(c,c->argv[j],&id,0) != C_OK) return;
}
int acknowledged = 0;
for (int j = 3; j < c->argc; j++) {
streamID id;
unsigned char buf[sizeof(streamID)];
if (streamParseStrictIDOrReply(c,c->argv[j],&id,0) != C_OK) return;
if (streamParseStrictIDOrReply(c,c->argv[j],&id,0) != C_OK)
serverPanic("StreamID invalid after check. Should not be possible.");
streamEncodeID(buf,&id);
/* Lookup the ID in the group PEL: it will have a reference to the