fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-05-03 14:32:14 +00:00
Code Issues Projects Releases Wiki Activity

Abstract hllSparseAdd() / hllDenseAdd() via hllAdd().

Browse Source
This commit is contained in:
antirez 2014-04-12 23:42:48 +02:00
parent 0b7d08efb9
commit a9e057e095
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/hyperloglog.c
View File

@ -909,6 +909,16 @@ uint64_t hllCount(struct hllhdr *hdr) {
return (uint64_t) E; return (uint64_t) E;
} }
/* Call hllDenseAdd() or hllSparseAdd() according to the HLL encoding. */
int hllAdd(robj *o, unsigned char *ele, size_t elesize) {
struct hllhdr *hdr = o->ptr;
switch(hdr->encoding) {
case HLL_DENSE: return hllDenseAdd(hdr->registers,ele,elesize);
case HLL_SPARSE: return hllSparseAdd(o,ele,elesize);
default: return -1; /* Invalid representation. */
}
}
/* ========================== HyperLogLog commands ========================== */ /* ========================== HyperLogLog commands ========================== */
/* Create an HLL object. We always create the HLL using sparse encoding. /* Create an HLL object. We always create the HLL using sparse encoding.
@ -996,14 +1006,19 @@ void pfaddCommand(redisClient *c) {
o = dbUnshareStringValue(c->db,c->argv[1],o); o = dbUnshareStringValue(c->db,c->argv[1],o);
} }
/* Perform the low level ADD operation for every element. */ /* Perform the low level ADD operation for every element. */
hdr = o->ptr;
for (j = 2; j < c->argc; j++) { for (j = 2; j < c->argc; j++) {
if (hllDenseAdd(hdr->registers, (unsigned char*)c->argv[j]->ptr, int retval = hllAdd(o, (unsigned char*)c->argv[j]->ptr,
sdslen(c->argv[j]->ptr))) sdslen(c->argv[j]->ptr));
{ switch(retval) {
case 1:
updated++; updated++;
break;
case -1:
addReplyError(c,"Invalid HyperLogLog representation");
return;
} }
} }
hdr = o->ptr;
if (updated) { if (updated) {
signalModifiedKey(c->db,c->argv[1]); signalModifiedKey(c->db,c->argv[1]);
notifyKeyspaceEvent(REDIS_NOTIFY_STRING,"pfadd",c->argv[1],c->db->id); notifyKeyspaceEvent(REDIS_NOTIFY_STRING,"pfadd",c->argv[1],c->db->id);