fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-06-13 01:01:22 +00:00
Code Issues Projects Releases Wiki Activity

Disable negative offsets for SETRANGE

Browse Source
This commit is contained in:
Pieter Noordhuis
2010-12-15 11:30:50 +01:00
parent e983cf34be
commit 8f8eeffec1
2 changed files with 7 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/t_string.c
View File

@ -195,11 +195,13 @@ void setrangeCommand(redisClient *c) {
if (getLongFromObjectOrReply(c,c->argv[2],&offset,NULL) != REDIS_OK)
return;
if (offset < 0) {
addReplyError(c,"offset is out of range");
return;
}
o = lookupKeyWrite(c->db,c->argv[1]);
if (o == NULL) {
/* Negative offset is always 0 for non-existing keys */
if (offset < 0) offset = 0;
/* Return 0 when setting nothing on a non-existing string */
if (sdslen(value) == 0) {
addReply(c,shared.czero);
@ -233,15 +235,6 @@ void setrangeCommand(redisClient *c) {
return;
}
/* Convert negative indexes. Note that for SETRANGE, the meaning of a
* negative index is a little different than for other commands.
* Here, an offset of -1 points to the trailing NULL byte of the
* string instead of the last character. */
if (offset < 0) {
offset = olen+1+offset;
if (offset < 0) offset = 0;
}
/* Return when the resulting string exceeds allowed size */
if (checkStringLength(c,offset+sdslen(value)) != REDIS_OK)
return;