retval doesn't initalized

If each if conditions are all fail, variable retval will under uninitlized
This commit is contained in:
Rock Li 2013-02-05 15:56:04 +08:00 committed by antirez
parent 63dc34bd01
commit 8c0b9f778e

View File

@ -472,7 +472,7 @@ void srandmemberWithCountCommand(redisClient *c) {
/* Add all the elements into the temporary dictionary. */ /* Add all the elements into the temporary dictionary. */
si = setTypeInitIterator(set); si = setTypeInitIterator(set);
while((encoding = setTypeNext(si,&ele,&llele)) != -1) { while((encoding = setTypeNext(si,&ele,&llele)) != -1) {
int retval; int retval = DICT_ERR;
if (encoding == REDIS_ENCODING_INTSET) { if (encoding == REDIS_ENCODING_INTSET) {
retval = dictAdd(d,createStringObjectFromLongLong(llele),NULL); retval = dictAdd(d,createStringObjectFromLongLong(llele),NULL);