Test suite: new --stop option.

It pauses the test execution once the first failure is found.
This commit is contained in:
antirez 2018-08-02 18:49:49 +02:00
parent d506334b67
commit 26897c03e2

View File

@ -89,6 +89,7 @@ set ::last_progress [clock seconds]
set ::active_servers {} ; # Pids of active Redis instances. set ::active_servers {} ; # Pids of active Redis instances.
set ::dont_clean 0 set ::dont_clean 0
set ::wait_server 0 set ::wait_server 0
set ::stop_on_failure 0
# Set to 1 when we are running in client mode. The Redis test uses a # Set to 1 when we are running in client mode. The Redis test uses a
# server-client model to run tests simultaneously. The server instance # server-client model to run tests simultaneously. The server instance
@ -302,6 +303,11 @@ proc read_from_test_client fd {
puts $err puts $err
lappend ::failed_tests $err lappend ::failed_tests $err
set ::active_clients_task($fd) "(ERR) $data" set ::active_clients_task($fd) "(ERR) $data"
if {$::stop_on_failure} {
puts -nonewline "(Test stopped, press enter to continue)"
flush stdout
gets stdin
}
} elseif {$status eq {exception}} { } elseif {$status eq {exception}} {
puts "\[[colorstr red $status]\]: $data" puts "\[[colorstr red $status]\]: $data"
kill_clients kill_clients
@ -433,10 +439,11 @@ proc print_help_screen {} {
"--clients <num> Number of test clients (default 16)." "--clients <num> Number of test clients (default 16)."
"--timeout <sec> Test timeout in seconds (default 10 min)." "--timeout <sec> Test timeout in seconds (default 10 min)."
"--force-failure Force the execution of a test that always fails." "--force-failure Force the execution of a test that always fails."
"--config <k> <v> extra config file argument" "--config <k> <v> Extra config file argument"
"--skipfile <file> name of a file containing test names that should be skipped (one per line)" "--skipfile <file> Name of a file containing test names that should be skipped (one per line)"
"--dont-clean don't delete redis log files after the run" "--dont-clean Don't delete redis log files after the run"
"--wait-server wait after server is started (so that you can attach a debugger)" "--stop Blocks once the first test fails"
"--wait-server Wait after server is started (so that you can attach a debugger)"
"--help Print this help screen." "--help Print this help screen."
} "\n"] } "\n"]
} }
@ -511,6 +518,8 @@ for {set j 0} {$j < [llength $argv]} {incr j} {
set ::dont_clean 1 set ::dont_clean 1
} elseif {$opt eq {--wait-server}} { } elseif {$opt eq {--wait-server}} {
set ::wait_server 1 set ::wait_server 1
} elseif {$opt eq {--stop}} {
set ::stop_on_failure 1
} elseif {$opt eq {--timeout}} { } elseif {$opt eq {--timeout}} {
set ::timeout $arg set ::timeout $arg
incr j incr j