mirror of
https://github.com/fluencelabs/musl
synced 2025-04-26 07:42:13 +00:00
a6adb2bcd8
previously we detected this bug in configure and issued advice for a workaround, but this turned out not to work. since then gcc 4.9.0 has appeared in several distributions, and now 4.9.1 has been released without a fix despite this being a wrong code generation bug which is supposed to be a release-blocker, per gcc policy. since the scope of the bug seems to affect only data objects (rather than functions) whose definitions are overridable, and there are only a very small number of these in musl, I am just changing them from const to volatile for the time being. simply removing the const would be sufficient to make gcc 4.9.1 work (the non-const case was inadvertently fixed as part of another change in gcc), and this would also be sufficient with 4.9.0 if we forced -O0 on the affected files or on the whole build. however it's cleaner to just remove all the broken compiler detection and use volatile, which will ensure that they are never constant-folded. the quality of a non-broken compiler's output should not be affected except for the fact that these objects are no longer const and thus possibly add a few bytes to data/bss. this change can be reconsidered and possibly reverted at some point in the future when the broken gcc versions are no longer relevant.
17 lines
334 B
C
17 lines
334 B
C
#include "stdio_impl.h"
|
|
|
|
static unsigned char buf[BUFSIZ+UNGET];
|
|
static FILE f = {
|
|
.buf = buf+UNGET,
|
|
.buf_size = sizeof buf-UNGET,
|
|
.fd = 1,
|
|
.flags = F_PERM | F_NORD,
|
|
.lbf = '\n',
|
|
.write = __stdout_write,
|
|
.seek = __stdio_seek,
|
|
.close = __stdio_close,
|
|
.lock = -1,
|
|
};
|
|
FILE *const stdout = &f;
|
|
FILE *volatile __stdout_used = &f;
|